Re: [PATCH v5 3/9] KVM: selftests: SEV-SNP test for KVM_SEV_INIT2

Pratik Rajesh Sampat
2025-01-28T17:35:12Z

Hi Nikunj

On 1/28/25 6:13 AM, Nikunj A Dadhania wrote:
> "Pratik R. Sampat" <prsampat@amd.com> writes:
>
>> Add the X86_FEATURE_SNP CPU feature to the architectural definition for
>> the SEV-SNP VM type to exercise the KVM_SEV_INIT2 call. Ensure that the
>> SNP test is skipped in scenarios where CPUID supports it but KVM does
>> not, preventing reporting of failure in such cases.
>>
>> Signed-off-by: Pratik R. Sampat <prsampat@amd.com>
>
> With a minor nit below:
>
> Reviewed-by: Nikunj A Dadhania <nikunj@amd.com>
>
>> ---
>> tools/testing/selftests/kvm/include/x86/processor.h | 1 +
>> tools/testing/selftests/kvm/x86/sev_init2_tests.c | 13 +++++++++++++
>> 2 files changed, 14 insertions(+)
>>
>> diff --git a/tools/testing/selftests/kvm/include/x86/processor.h b/tools/testing/selftests/kvm/include/x86/processor.h
>> index d60da8966772..1e05e610bb06 100644
>> --- a/tools/testing/selftests/kvm/include/x86/processor.h
>> +++ b/tools/testing/selftests/kvm/include/x86/processor.h
>> @@ -199,6 +199,7 @@ struct kvm_x86_cpu_feature {
>> #define X86_FEATURE_VGIF KVM_X86_CPU_FEATURE(0x8000000A, 0, EDX, 16)
>> #define X86_FEATURE_SEV KVM_X86_CPU_FEATURE(0x8000001F, 0, EAX, 1)
>> #define X86_FEATURE_SEV_ES KVM_X86_CPU_FEATURE(0x8000001F, 0, EAX, 3)
>> +#define X86_FEATURE_SNP KVM_X86_CPU_FEATURE(0x8000001F, 0, EAX, 4)
>
> Can we keep the naming same as in cpufeatures.h: X86_FEATURE_SEV_SNP ?
>

Thanks for your reviews!

Overall, I was trying to be consistent with KVM by dropping the SEV
prefix from SNP in the rest of the SEV library to improve brevity and
reduce line clutter. However, for consistency with cpufeatures.h, I can
change this instance to include the SEV infix as well.

Pratik