From: Pavel Fedin <p.fedin@samsung.com>
To: 'Christoffer Dall' <christoffer.dall@linaro.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
'Marc Zyngier' <marc.zyngier@arm.com>,
'Andre Przywara' <andre.przywara@arm.com>
Subject: RE: [PATCH v3 2/3] KVM: arm/arm64: Merge vgic_set_lr() and vgic_sync_lr_elrsr()
Date: Tue, 27 Oct 2015 09:56:47 +0300 [thread overview]
Message-ID: <00b001d11084$a6347c00$f29d7400$@samsung.com> (raw)
In-Reply-To: <20151026194205.GG20298@cbox>
Hello!
> > --- cut ---
> > Additionally, remove unnecessary vgic_set_lr() and LR_STATE_PENDING check
> > in vgic_unqueue_irqs(), because all these things are now done by the
> > following vgic_retire_lr().
> > --- cut ---
>
> This does not explain the question I'm raising.
>
> After applying this patch, and before applying your next patch,
> unqueueing an IRQ will not restore the pending state on the
> distributor, but just throw that piece of state away
It will restore the state and not throw it away.
I guess i'm just not clear enough and you misunderstand me. This check in vgic_unqueue_irqs() is redundant from the beginning.
Let's look at current vgic_retire_lr():
https://git.kernel.org/cgit/linux/kernel/git/kvmarm/kvmarm.git/tree/virt/kvm/arm/vgic.c?h=next#n1099
It already does LR_STATE_PENDING check and pushback by itself, since cff9211eb1a1f58ce7f5a2d596b617928fd4be0e (it's your commit,
BTW), so that this check:
https://git.kernel.org/cgit/linux/kernel/git/kvmarm/kvmarm.git/tree/virt/kvm/arm/vgic.c?h=next#n728
is already redundant. So actually this is a separate change, and perhaps it's my fault to squash it in.
> which breaks bisectability and makes it impossible to understand the logic by looking
> at this commit in isolation.
Will this be understood better if i make this particular refactor a separate commit, with better explanations?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-27 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 9:00 [PATCH v3 0/3] KVM: arm/arm64: Clean up some obsolete code Pavel Fedin
2015-10-26 9:00 ` [PATCH v3 1/3] KVM: arm/arm64: Optimize away redundant LR tracking Pavel Fedin
2015-10-26 9:00 ` [PATCH v3 2/3] KVM: arm/arm64: Merge vgic_set_lr() and vgic_sync_lr_elrsr() Pavel Fedin
2015-10-26 15:22 ` Christoffer Dall
2015-10-26 15:49 ` Pavel Fedin
2015-10-26 19:42 ` Christoffer Dall
2015-10-27 6:56 ` Pavel Fedin [this message]
2015-10-26 9:00 ` [PATCH v3 3/3] KVM: arm/arm64: Refactor vgic_retire_lr() Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b001d11084$a6347c00$f29d7400$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).