Re: [PATCH v1 06/40] i386/tdx: Get tdx_capabilities via KVM_TDX_CAPABILITIES

Xiaoyao Li
2022-08-25T15:35:46Z

On 8/25/2022 6:12 PM, Gerd Hoffmann wrote:
> Hi,
>
>> + r = tdx_platform_ioctl(KVM_TDX_CAPABILITIES, 0, caps);
>> + if (r == -E2BIG) {
>> + g_free(caps);
>> + nr_cpuid_configs *= 2;
>> + if (nr_cpuid_configs > KVM_MAX_CPUID_ENTRIES) {
>> + error_report("KVM TDX seems broken");
>
> Maybe, but IMHO this should still report what exactly the problem is
> (number of cpuid entries exceeds limit).

Will update it to

error_report(KVM TDX seems broken that number of CPUID entries in
kvm_tdx_capabilities exceeds limit)

> take care,
> Gerd
>
>