public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Leendert van Doorn" <leendert@paramecium.org>
To: "'Avi Kivity'" <avi@redhat.com>, "'Kevin O'Connor'" <kevin@koconnor.net>
Cc: "'Shan, Haitao'" <haitao.shan@intel.com>,
	"'Liu, Kechao'" <kechao.liu@intel.com>, <kvm@vger.kernel.org>
Subject: RE: [PATCH][v2] kvm-userspace: Load PCI option ROMs
Date: Sun, 4 Jan 2009 11:54:09 -0600	[thread overview]
Message-ID: <010201c96e95$72cd4f10$5867ed30$@org> (raw)
In-Reply-To: <4960F1D2.4080600@redhat.com>

Avi wrote:

> Surely, the BIOS call interface is a GPL boundary, just like the Linux 
> syscall interface.  Kevin, is that not the case?  If it is a GPL 
> interface, can you add an explicit exception to make it clear?

At IBM we had many discussions about what precisely constitutes a GPL
boundary. Especially when you are examining internal BIOS data structures
(which most kernels do when accessing the BIOS). In the end Legal advised us
that LGPL was ok and GPL was not. This was all in the context of v2 so
things may have changed with v3.

I don't want this to turn into a GPL versus LGPL argument because I'm not a
lawyer either. If the KVM project picks up SEABIOS I'm all for it because it
is much cleaner and easier to maintain.

>> Ensuring
>> the same mappings was much cleaner.

> With a switch, please.  Default behaviour should be to virtualize.
> 
> One way to implement it is to pass pci devfn -> BAR hints through the 
> firmware interface.  This way you can choose which BARs to place where, 
> and where to allow the default placement.

I'm already providing the hints, but you are proposing that the default
behavior for the BIOS should be to allocate BARs and when given a flag it
should try to preserve the host BAR mappings. I can do that.

>> Of course, my goal is to run unmodified BIOS/drivers. You could always
>> change the drivers.
>
> Not Windows drivers.

Well, at least I have a fighting chance to change the ATI windows drivers
:-)

	Leendert


  parent reply	other threads:[~2009-01-04 17:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-29  3:51 [PATCH][v2] kvm-userspace: Load PCI option ROMs Liu, Kechao
2008-12-29  8:28 ` Avi Kivity
2008-12-29  9:36   ` Liu, Kechao
2008-12-29  9:49     ` Avi Kivity
2008-12-30  1:01       ` Shan, Haitao
2008-12-30 15:51         ` Avi Kivity
2008-12-31  2:06           ` Shan, Haitao
2008-12-31  9:28             ` Avi Kivity
2009-01-03  2:29               ` Shan, Haitao
2009-01-04  2:12               ` Shan, Haitao
2009-01-04  3:54                 ` Leendert van Doorn
2009-01-04  4:58                   ` Shan, Haitao
2009-01-04 10:26                   ` Avi Kivity
2009-01-04 17:12                     ` Leendert van Doorn
2009-01-04 17:28                       ` Avi Kivity
2009-01-04 17:29                         ` Avi Kivity
2009-01-04 17:54                         ` Leendert van Doorn [this message]
2009-01-04 19:51                           ` Avi Kivity
2009-01-04 18:03                         ` Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='010201c96e95$72cd4f10$5867ed30$@org' \
    --to=leendert@paramecium.org \
    --cc=avi@redhat.com \
    --cc=haitao.shan@intel.com \
    --cc=kechao.liu@intel.com \
    --cc=kevin@koconnor.net \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox