From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Fedin Subject: RE: [PATCH] KVM: arm64: Decode basic HYP fault information Date: Mon, 31 Aug 2015 09:33:40 +0300 Message-ID: <012d01d0e3b6$fa327c30$ee977490$@samsung.com> References: <00aa01d0d408$1ba96ea0$52fc4be0$@samsung.com> <20150830174434.GG24113@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, 'Marc Zyngier' To: 'Christoffer Dall' Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:14379 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbbHaGdn (ORCPT ); Mon, 31 Aug 2015 02:33:43 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NTX00L8VOW5E180@mailout1.w1.samsung.com> for kvm@vger.kernel.org; Mon, 31 Aug 2015 07:33:41 +0100 (BST) In-reply-to: <20150830174434.GG24113@cbox> Content-language: ru Sender: kvm-owner@vger.kernel.org List-ID: Hello! > my overall concern with this patch is that it adds complexity to an > already really bad situation, and potentially increases the likelihood > of not seeing any debug info at all. Why? In this case we currently already drop into C code. I do the same, with some more useful printout. What is fundamentally changed? > do you encounter this kind of panic a lot? I haven't experienced a > great need for more hyp debugging help lately... I met it once, and i had a stable way to reproduce it. At the end it appeared to be another HW quirk, but, still, this patch helped a lot to find out what was wrong. The main missing information was vector number, and translated PC is also useful. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia