Re: [PATCH v2 06/11] target/ppc/kvm: Remove kvmppc_get_host_serial() as unused

Chinmay Rath
2025-10-21T11:36:58Z

On 10/21/25 14:13, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/ppc/kvm_ppc.h | 6 ------
> target/ppc/kvm.c | 6 ------
> 2 files changed, 12 deletions(-)
>
> diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h
> index a1d9ce9f9aa..f24cc4de3c2 100644
> --- a/target/ppc/kvm_ppc.h
> +++ b/target/ppc/kvm_ppc.h
> @@ -22,7 +22,6 @@
> uint32_t kvmppc_get_tbfreq(void);
> uint64_t kvmppc_get_clockfreq(void);
> bool kvmppc_get_host_model(char **buf);
> -bool kvmppc_get_host_serial(char **buf);
> int kvmppc_get_hasidle(CPUPPCState *env);
> int kvmppc_get_hypercall(CPUPPCState *env, uint8_t *buf, int buf_len);
> int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level);
> @@ -134,11 +133,6 @@ static inline bool kvmppc_get_host_model(char **buf)
> return false;
> }
>
> -static inline bool kvmppc_get_host_serial(char **buf)
> -{
> - return false;
> -}
> -
> static inline uint64_t kvmppc_get_clockfreq(void)
> {
> return 0;
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index cd60893a17d..cb61e99f9d4 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -1864,12 +1864,6 @@ uint32_t kvmppc_get_tbfreq(void)
> return cached_tbfreq;
> }
>
> -bool kvmppc_get_host_serial(char **value)
> -{
> - return g_file_get_contents("/proc/device-tree/system-id", value, NULL,
> - NULL);
> -}
> -
> bool kvmppc_get_host_model(char **value)
> {
> return g_file_get_contents("/proc/device-tree/model", value, NULL, NULL);
Reviewed-by: Chinmay Rath <rathc@linux.ibm.com>