From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH V2 2/4] Utilize the vmx preemption timer Date: Tue, 14 Jun 2016 23:56:27 +0200 Message-ID: <030a53f9-34ef-a0cb-3bb8-035e95dfa7dd@redhat.com> References: <1464128852-14138-1-git-send-email-yunhong.jiang@linux.intel.com> <1464128852-14138-3-git-send-email-yunhong.jiang@linux.intel.com> <20160614125537.b3qlcjytjb64ezht@rkaganb.sw.ru> <27f8a049-4e8f-27fd-8fe2-6121f6218f25@redhat.com> <20160614094606.3fc0ed03@jnakajim-build> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Roman Kagan , kvm@vger.kernel.org, mtosatti@redhat.com, rkrcmar@redhat.com, kernellwp@gmail.com To: yunhong jiang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33839 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbcFNV4b (ORCPT ); Tue, 14 Jun 2016 17:56:31 -0400 In-Reply-To: <20160614094606.3fc0ed03@jnakajim-build> Sender: kvm-owner@vger.kernel.org List-ID: On 14/06/2016 18:46, yunhong jiang wrote: > On Tue, 14 Jun 2016 15:41:07 +0200 > Paolo Bonzini wrote: > >> >> >> On 14/06/2016 15:23, Roman Kagan wrote: >>>>> >>>>> +static int cpu_preemption_timer_multi; >>>>> +static bool __read_mostly enable_hv_timer; >>>>> +module_param_named(enable_hv_timer, enable_hv_timer, bool, >>>>> S_IRUGO); + >>> Non-techincal issue: I think the naming for the parameter is >>> unfortunate, as it looks similar to a number of CPU properties in >>> QEMU that start with "hv-", which are all related to MS Hyper-V >>> compatibility features. >> >> Non-technical but important. Let's change it to preemption_timer (and >> the variable to enable_preemption_timer). >> >> The code can keep the "hv_timer" moniker though. > > Hi, Paolo, should I resend the patch for this change? No, no need to. I've already pushed the patches to kvm/queue. I've also separated all vmx bits to one patch and x86 to another. Paolo