From: Dave Hansen <dave.hansen@intel.com>
To: Kiryl Shutsemau <kas@kernel.org>
Cc: Challvy Tee <challvy.tee@gmail.com>,
x86@kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
regressions@lists.linux.dev, stable@vger.kernel.org,
dave.hansen@linux.intel.com, rick.p.edgecombe@intel.com,
vishal.l.verma@intel.com, kai.huang@intel.com, seanjc@google.com
Subject: Re: [PATCH v3] x86/virt/tdx: Skip TDH.SYS.DISABLE if the TDX module is not initialized
Date: Fri, 30 Oct 2026 09:38:21 -0700 [thread overview]
Message-ID: <07cfa95a-e766-411b-8765-33352a04c0be@intel.com> (raw)
In-Reply-To: <auTExTAMoaKKjBrb@thinkstation>
On 10/30/26 09:26, Kiryl Shutsemau wrote:
>>
>> If SEAMCALL is fatal then we need stronger barriers on the generic paths
>> to SEAMCALLs themselves, not one-off patches of the sites.
> I don't think the generic path is the right place for it. For every
> other caller, reaching a SEAMCALL on a non-TDX system means something
> went wrong higher up, and we want to see it. A check there that quietly
> returns an error hides that. Making it WARN would catch it, but then the
> crash path would still need its own check before the call.
>
> So gate the call on X86_FEATURE_TDX_HOST_PLATFORM, the same way
> paddr_is_tdx_private() does.
Sounds fine to me.
prev parent reply other threads:[~2026-10-30 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <auM3KKutfutAqgWG@thinkstation>
2026-10-30 15:48 ` [PATCH v3] x86/virt/tdx: Skip TDH.SYS.DISABLE if the TDX module is not initialized Challvy Tee
2026-10-30 16:13 ` Dave Hansen
2026-10-30 16:26 ` Kiryl Shutsemau
2026-10-30 16:38 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07cfa95a-e766-411b-8765-33352a04c0be@intel.com \
--to=dave.hansen@intel.com \
--cc=challvy.tee@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=kai.huang@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox