From: JinrongLiang <ljr.kernel@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
Liam Merwick <liam.merwick@oracle.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Joerg Roedel <joro@8bytes.org>,
Jinrong Liang <cloudliang@tencent.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: kvm: Fix a compile error in selftests/kvm/rseq_test.c
Date: Fri, 16 Sep 2022 18:02:48 +0800 [thread overview]
Message-ID: <08cd7add-b2a5-da3f-1d2c-efa0e7c80511@gmail.com> (raw)
In-Reply-To: <fdfb143a-45c4-aaff-aa95-d20c076ff555@oracle.com>
On 2022/9/8 00:54, Liam Merwick wrote:
> On 07/09/2022 17:01, Sean Christopherson wrote:
>> On Tue, Aug 02, 2022, Jinrong Liang wrote:
>>> From: Jinrong Liang <cloudliang@tencent.com>
>>>
>>> The following warning appears when executing:
>>> make -C tools/testing/selftests/kvm
>>>
>>> rseq_test.c: In function ‘main’:
>>> rseq_test.c:237:33: warning: implicit declaration of function
>>> ‘gettid’; did you mean ‘getgid’? [-Wimplicit-function-declaration]
>>> (void *)(unsigned long)gettid());
>>> ^~~~~~
>>> getgid
>>> /usr/bin/ld: /tmp/ccr5mMko.o: in function `main':
>>> ../kvm/tools/testing/selftests/kvm/rseq_test.c:237: undefined
>>> reference to `gettid'
>>> collect2: error: ld returned 1 exit status
>>> make: *** [../lib.mk:173:
>>> ../kvm/tools/testing/selftests/kvm/rseq_test] Error 1
>>>
>>> Use the more compatible syscall(SYS_gettid) instead of gettid() to
>>> fix it.
>>> More subsequent reuse may cause it to be wrapped in a lib file.
>>>
>>> Signed-off-by: Jinrong Liang <cloudliang@tencent.com>
>>> ---
>>
>> Reviewed-by: Sean Christopherson <seanjc@google.com>
>>
>
> Can a 'Cc: stable@vger.kernel.org' be added also as e923b0537d28 got
> backported to v5.15.58
>
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
>
>
>>
>> Paolo, do you want to grab this for 6.0? It doesn't look like we're
>> going to have
>> a more elegant solution anytime soon...
>
Ping?
next prev parent reply other threads:[~2022-09-16 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:12 [PATCH] selftests: kvm: Fix a compile error in selftests/kvm/rseq_test.c Jinrong Liang
2022-08-02 15:08 ` Andrew Jones
2022-08-03 13:58 ` Jinrong Liang
2022-08-03 14:26 ` Andrew Jones
2022-08-03 16:10 ` Sean Christopherson
2022-08-03 17:26 ` Andrew Jones
2022-08-04 23:41 ` Sean Christopherson
2022-09-07 16:01 ` Sean Christopherson
2022-09-07 16:54 ` Liam Merwick
2022-09-16 10:02 ` JinrongLiang [this message]
2022-09-21 23:29 ` David Matlack
2022-09-22 21:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cd7add-b2a5-da3f-1d2c-efa0e7c80511@gmail.com \
--to=ljr.kernel@gmail.com \
--cc=cloudliang@tencent.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=liam.merwick@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox