Re: [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name

Cornelia Huck
2021-02-10T11:08:55Z

On Tue, 9 Feb 2021 16:57:05 +0100
Thomas Huth <thuth@redhat.com> wrote:

> sizeof(somepointer) results in the size of the pointer, i.e. 8 on a
> 64-bit system, so the
>
> memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext))
>
> only compared the first 8 characters of the VM name here. Switch
> to a proper array to get the sizeof() right.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> s390x/stsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>