Re: [PATCH v3 1/9] iommu: Pass old domain to set_dev_pasid op

[Baolu Lu <baolu.lu@linux.intel.com>]

On 2024/10/18 13:53, Yi Liu wrote:
> To support domain replacement for pasid, the underlying iommu driver needs
> to know the old domain hence be able to clean up the existing attachment.
> It would be much convenient for iommu layer to pass down the old domain.
> Otherwise, iommu drivers would need to track domain for pasids by themselves,
> this would duplicate code among the iommu drivers. Or iommu drivers would
> rely group->pasid_array to get domain, which may not always the correct
> one.
> 
> Suggested-by: Jason Gunthorpe<jgg@nvidia.com>
> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
> Reviewed-by: Kevin Tian<kevin.tian@intel.com>
> Signed-off-by: Yi Liu<yi.l.liu@intel.com>
> ---
>   drivers/iommu/amd/amd_iommu.h                   | 3 ++-
>   drivers/iommu/amd/pasid.c                       | 3 ++-
>   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 3 ++-
>   drivers/iommu/intel/iommu.c                     | 6 ++++--
>   drivers/iommu/intel/svm.c                       | 3 ++-
>   drivers/iommu/iommu.c                           | 3 ++-
>   include/linux/iommu.h                           | 2 +-
>   7 files changed, 15 insertions(+), 8 deletions(-)

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Thanks,
baolu