From: Janosch Frank <frankja@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org
Cc: Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Sebastian Mitterle <smitterl@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v1 1/2] s390x: make smp_cpu_setup() return 0 on success
Date: Thu, 2 Dec 2021 12:28:55 +0100 [thread overview]
Message-ID: <0b4dff4c-62d4-a656-69e8-bc3ea356f7ae@linux.ibm.com> (raw)
In-Reply-To: <20211202095843.41162-2-david@redhat.com>
On 12/2/21 10:58, David Hildenbrand wrote:
> Properly return "0" on success so callers can check if the setup was
> successful.
>
> The return value is yet unused, which is why this wasn't noticed so far.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> lib/s390x/smp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/s390x/smp.c b/lib/s390x/smp.c
> index da6d32f..b753eab 100644
> --- a/lib/s390x/smp.c
> +++ b/lib/s390x/smp.c
> @@ -212,6 +212,7 @@ int smp_cpu_setup(uint16_t addr, struct psw psw)
> /* Wait until the cpu has finished setup and started the provided psw */
> while (lc->restart_new_psw.addr != psw.addr)
> mb();
> + rc = 0;
> out:
> spin_unlock(&lock);
> return rc;
>
oops
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2021-12-02 11:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:58 [kvm-unit-tests PATCH v1 0/2] s390x: firq: floating interrupt test David Hildenbrand
2021-12-02 9:58 ` [kvm-unit-tests PATCH v1 1/2] s390x: make smp_cpu_setup() return 0 on success David Hildenbrand
2021-12-02 10:30 ` Thomas Huth
2021-12-02 10:33 ` Claudio Imbrenda
2021-12-02 11:28 ` Janosch Frank [this message]
2021-12-02 9:58 ` [kvm-unit-tests PATCH v1 2/2] s390x: firq: floating interrupt test David Hildenbrand
2021-12-02 11:01 ` Claudio Imbrenda
2021-12-02 11:13 ` David Hildenbrand
2021-12-02 11:26 ` David Hildenbrand
2021-12-02 12:07 ` Claudio Imbrenda
2021-12-02 12:24 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4dff4c-62d4-a656-69e8-bc3ea356f7ae@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=smitterl@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox