public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: "Moger, Babu" <bmoger@amd.com>, Babu Moger <babu.moger@amd.com>,
	<corbet@lwn.net>, <tony.luck@intel.com>, <Dave.Martin@arm.com>,
	<james.morse@arm.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<bp@alien8.de>, <dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <kas@kernel.org>,
	<rick.p.edgecombe@intel.com>, <akpm@linux-foundation.org>,
	<paulmck@kernel.org>, <pmladek@suse.com>,
	<pawan.kumar.gupta@linux.intel.com>, <rostedt@goodmis.org>,
	<kees@kernel.org>, <arnd@arndb.de>, <fvdl@google.com>,
	<seanjc@google.com>, <thomas.lendacky@amd.com>,
	<manali.shukla@amd.com>, <perry.yuan@amd.com>,
	<sohil.mehta@intel.com>, <xin@zytor.com>, <peterz@infradead.org>,
	<mario.limonciello@amd.com>, <gautham.shenoy@amd.com>,
	<nikunj@amd.com>, <dapeng1.mi@linux.intel.com>,
	<ak@linux.intel.com>, <chang.seok.bae@intel.com>,
	<ebiggers@google.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-coco@lists.linux.dev>,
	<kvm@vger.kernel.org>
Subject: Re: [PATCH v9 09/10] fs/resctrl: Introduce interface to modify io_alloc Capacity Bit Masks
Date: Mon, 22 Sep 2025 15:48:29 -0700	[thread overview]
Message-ID: <0c110b5f-de24-4ffd-bc9c-3597493bab7d@intel.com> (raw)
In-Reply-To: <7c6a4f7e-e810-4d81-b01d-b0cbf644472f@amd.com>

Hi Babu,

On 9/19/25 1:49 PM, Moger, Babu wrote:
 
> Here is the updated full changelog.
> 
> fs/resctrl: Introduce interface to modify io_alloc Capacity Bit Masks

I do not think it is necessary to use upper case if not following it
by the acronym. I also think "bitmask" is usually one word? So:
	fs/resctrl: Introduce interface to modify io_alloc capacity bitmasks

> 
> The io_alloc feature in resctrl enables system software to configure the
> portion of the cache allocated for I/O traffic. When supported, the
> io_alloc_cbm file in resctrl provides access to Capacity Bit Masks (CBMs) allocated for I/O devices.
> 
> Enable users to modify io_alloc CBMs via io_alloc_cbm resctrl file when the feature is enabled.

(nit) can be made more specific with:

	Enable users to modify io_alloc CBMs by writing to the io_alloc_cbm resctrl
	file when the io_alloc feature is enabled.

> 
> Mirror the CBMs between CDP_CODE and CDP_DATA when CDP is enabled to present consistent I/O allocation information to user space and keep both resource types synchronized.

I think "and keep both resource types synchronized" is redundant considering the sentence
starts with "Mirror the CBMs"?

Reinette


  reply	other threads:[~2025-09-22 22:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 22:41 [PATCH v9 00/10] x86,fs/resctrl: Support L3 Smart Data Cache Injection Allocation Enforcement (SDCIAE) Babu Moger
2025-09-02 22:41 ` [PATCH v9 01/10] x86/cpufeatures: Add support for L3 Smart Data Cache Injection Allocation Enforcement Babu Moger
2025-09-18  5:08   ` Reinette Chatre
2025-09-19 15:45     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 02/10] x86/resctrl: Add SDCIAE feature in the command line options Babu Moger
2025-09-18  5:09   ` Reinette Chatre
2025-09-19 16:40     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 03/10] x86,fs/resctrl: Detect io_alloc feature Babu Moger
2025-09-18  5:15   ` Reinette Chatre
2025-09-19 16:53     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 04/10] x86,fs/resctrl: Implement "io_alloc" enable/disable handlers Babu Moger
2025-09-18  5:19   ` Reinette Chatre
2025-09-19 17:18     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 05/10] fs/resctrl: Introduce interface to display "io_alloc" support Babu Moger
2025-09-18  5:28   ` Reinette Chatre
2025-09-19 17:49     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 06/10] fs/resctrl: Add user interface to enable/disable io_alloc feature Babu Moger
2025-09-18  5:37   ` Reinette Chatre
2025-09-19 19:09     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 07/10] fs/resctrl: Introduce interface to display io_alloc CBMs Babu Moger
2025-09-18  5:43   ` Reinette Chatre
2025-09-19 19:38     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 08/10] fs/resctrl: Modify rdt_parse_data to pass mode and CLOSID Babu Moger
2025-09-18  5:44   ` Reinette Chatre
2025-09-19 19:49     ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 09/10] fs/resctrl: Introduce interface to modify io_alloc Capacity Bit Masks Babu Moger
2025-09-18  6:03   ` Reinette Chatre
2025-09-19 20:49     ` Moger, Babu
2025-09-22 22:48       ` Reinette Chatre [this message]
2025-09-25 18:54         ` Moger, Babu
2025-09-02 22:41 ` [PATCH v9 10/10] fs/resctrl: Update bit_usage to reflect io_alloc Babu Moger
2025-09-18  6:08   ` Reinette Chatre
2025-09-19 21:05     ` Moger, Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c110b5f-de24-4ffd-bc9c-3597493bab7d@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=babu.moger@amd.com \
    --cc=bmoger@amd.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=corbet@lwn.net \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=ebiggers@google.com \
    --cc=fvdl@google.com \
    --cc=gautham.shenoy@amd.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=kas@kernel.org \
    --cc=kees@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manali.shukla@amd.com \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=nikunj@amd.com \
    --cc=paulmck@kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=perry.yuan@amd.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=seanjc@google.com \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox