From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A0B8C8300B for ; Thu, 30 Apr 2020 10:34:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48EE620838 for ; Thu, 30 Apr 2020 10:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZcKoqT3S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbgD3KeR (ORCPT ); Thu, 30 Apr 2020 06:34:17 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:22972 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725280AbgD3KeQ (ORCPT ); Thu, 30 Apr 2020 06:34:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588242855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O6Ku2Z3+7Gg0z8xz3T+AzovdxSe8hvidTw18x0PtX7U=; b=ZcKoqT3SCWV2lQL2m3LZf8qlzMLCaWjt9t4doD20ZykaNPoj7RjG210/rLAxn+kPTcj0j8 KvfbYadPLo7afBlmXsTNkrZJ6gXIxZELmt1fLaN0kqV8TqUV8YZhtqXtDQxabfWZiBwLo9 GnuloTRR0EypY3r3A59tHuqkZ0jYCF8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-q97_m3QiP0m2wqdqnmAnjg-1; Thu, 30 Apr 2020 06:34:13 -0400 X-MC-Unique: q97_m3QiP0m2wqdqnmAnjg-1 Received: by mail-wm1-f69.google.com with SMTP id h6so644792wmi.7 for ; Thu, 30 Apr 2020 03:34:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O6Ku2Z3+7Gg0z8xz3T+AzovdxSe8hvidTw18x0PtX7U=; b=dGUNnE9kB8XiswqEl3Hl+C148kMVdXYwnVlIMLa7T0f01o2x6YkfrX9t2LYZldAjuS JTC4L6A1weMhIELNDQOnWUchDmS8cd7LZUmnw5R0Ddm1Mgwr7YcpZcoY/gcUJzLGW+Bm aLCK/eqViwyJO0/sSwct1q0QuEJa5rqJHI0JtXXcdnG0Ok1jty7WxmitgQXcS9aaTsKv lcoPtt2VBZJRgdhu+SwEWu5pgRzqLXe7quA2kdmz517bLCviAs585PyhhCEEjy/Z93tW Tq3RFfTp2yW5lnjE4SNtZFSv5DaKIZ7YHuVvl3jSKIk4clXzKhIUXOhnZt2NFA/EKPLu ONBg== X-Gm-Message-State: AGi0Pub+fHWHgj35Fky4qb6KKZ5fvcWOZ/bPud1cZsG4mVckeijj4jX7 zOqr5MtnzBBYBftng7VnAxGNdXRP3dAOyK4dI42WWHKV8oKCcnA4cx7orR18Q0jFCZeMaVNj+zV +emp0KzISMXx1 X-Received: by 2002:a1c:2dc7:: with SMTP id t190mr2134804wmt.129.1588242852576; Thu, 30 Apr 2020 03:34:12 -0700 (PDT) X-Google-Smtp-Source: APiQypJ8JsQg/OP5zAqqUR3nxYzLoB/7jOFw1DIV0upZ3g5xdHI4OwLaHIfuoLdosbs8ImUknyql+g== X-Received: by 2002:a1c:2dc7:: with SMTP id t190mr2134792wmt.129.1588242852364; Thu, 30 Apr 2020 03:34:12 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:ac19:d1fb:3f5f:d54f? ([2001:b07:6468:f312:ac19:d1fb:3f5f:d54f]) by smtp.gmail.com with ESMTPSA id z22sm11673533wma.20.2020.04.30.03.34.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 03:34:11 -0700 (PDT) Subject: Re: [PATCH v1 00/15] Add support for Nitro Enclaves To: Alexander Graf , "Paraschiv, Andra-Irina" , linux-kernel@vger.kernel.org Cc: Anthony Liguori , Benjamin Herrenschmidt , Colm MacCarthaigh , Bjoern Doebel , David Woodhouse , Frank van der Linden , Martin Pohlack , Matt Wilson , Balbir Singh , Stewart Smith , Uwe Dannowski , kvm@vger.kernel.org, ne-devel-upstream@amazon.com References: <20200421184150.68011-1-andraprs@amazon.com> <18406322-dc58-9b59-3f94-88e6b638fe65@redhat.com> <2a4a15c5-7adb-c574-d558-7540b95e2139@redhat.com> <1ee5958d-e13e-5175-faf7-a1074bd9846d@amazon.com> <80489572-72a1-dbe7-5306-60799711dae0@amazon.com> <0467ce02-92f3-8456-2727-c4905c98c307@redhat.com> <5f8de7da-9d5c-0115-04b5-9f08be0b34b0@amazon.com> <095e3e9d-c9e5-61d0-cdfc-2bb099f02932@redhat.com> <602565db-d9a6-149a-0e1a-fe9c14a90ce7@amazon.com> <0a4c7a95-af86-270f-6770-0a283cec30df@amazon.com> From: Paolo Bonzini Message-ID: <0c919928-00ed-beda-e984-35f7b6ca42fb@redhat.com> Date: Thu, 30 Apr 2020 12:34:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <0a4c7a95-af86-270f-6770-0a283cec30df@amazon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 28/04/20 17:07, Alexander Graf wrote: > > Why don't we build something like the following instead? > >   vm = ne_create(vcpus = 4) >   ne_set_memory(vm, hva, len) >   ne_load_image(vm, addr, len) >   ne_start(vm) > > That way we would get the EIF loading into kernel space. "LOAD_IMAGE" > would only be available in the time window between set_memory and start. > It basically implements a memcpy(), but it would completely hide the > hidden semantics of where an EIF has to go, so future device versions > (or even other enclave implementers) could change the logic. Can we add a file format argument and flags to ne_load_image, to avoid having a v2 ioctl later? Also, would you consider a mode where ne_load_image is not invoked and the enclave starts in real mode at 0xffffff0? Thanks, Paolo