From: "Huang, Kai" <kai.huang@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"nikunj@amd.com" <nikunj@amd.com>
Cc: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
"santosh.shukla@amd.com" <santosh.shukla@amd.com>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH v3 5/5] KVM: SVM: Add Page modification logging support
Date: Mon, 29 Sep 2025 10:30:21 +0000 [thread overview]
Message-ID: <0d1baaecc56de2b77f82ab3af9c75a12be91d6b2.camel@intel.com> (raw)
In-Reply-To: <2b2ebc13-e4cd-4a05-98bf-8ca3959fb138@amd.com>
>
> I tested the above patch and it needed few SVM and x86 changes, here is a
> diff on top of your patch that works on SVM:
Ah thanks! I did build test but not sure why I missed some changes.
[...]
> --- a/arch/x86/kvm/svm/svm.h
> +++ b/arch/x86/kvm/svm/svm.h
> @@ -51,6 +51,7 @@ extern bool intercept_smi;
> extern bool x2avic_enabled;
> extern bool vnmi;
> extern int lbrv;
> +extern bool __read_mostly enable_pml;
I think this could be in <asm/kvm_host.h>, similar to enable_apicv?
VMX code needs it too.
next prev parent reply other threads:[~2025-09-29 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 10:10 [PATCH v3 0/5] KVM: SVM: Add Page Modification Logging (PML) support Nikunj A Dadhania
2025-09-25 10:10 ` [PATCH v3 1/5] KVM: x86: Carve out PML flush routine Nikunj A Dadhania
2025-09-25 10:10 ` [PATCH v3 2/5] KVM: x86: Move PML page to common vcpu arch structure Nikunj A Dadhania
2025-09-25 10:10 ` [PATCH v3 3/5] x86/cpufeatures: Add Page modification logging Nikunj A Dadhania
2025-09-25 10:10 ` [PATCH v3 4/5] KVM: SVM: Use BIT_ULL for 64-bit nested_ctl bit definitions Nikunj A Dadhania
2025-09-25 10:10 ` [PATCH v3 5/5] KVM: SVM: Add Page modification logging support Nikunj A Dadhania
2025-09-29 1:41 ` Huang, Kai
2025-09-29 8:52 ` Nikunj A. Dadhania
2025-09-29 10:30 ` Huang, Kai [this message]
2025-09-29 10:35 ` Nikunj A. Dadhania
2025-09-30 5:46 ` Nikunj A. Dadhania
2025-09-30 6:02 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d1baaecc56de2b77f82ab3af9c75a12be91d6b2.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox