From mboxrd@z Thu Jan 1 00:00:00 1970 From: Auger Eric Subject: Re: [PATCH 4/7] iommu: Add driver-not-bound notification Date: Wed, 14 Jun 2017 14:52:17 +0200 Message-ID: <101c5b72-ca00-6d5d-880e-1fc5fb123147@redhat.com> References: <20170609215816.31986.89321.stgit@gimli.home> <20170609215959.31986.60028.stgit@gimli.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Joerg Roedel , linux-kernel@vger.kernel.org To: Alex Williamson , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46764 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbdFNMw0 (ORCPT ); Wed, 14 Jun 2017 08:52:26 -0400 In-Reply-To: <20170609215959.31986.60028.stgit@gimli.home> Sender: kvm-owner@vger.kernel.org List-ID: Hi, On 09/06/2017 23:59, Alex Williamson wrote: > The driver core supports a BUS_NOTIFY_DRIVER_NOT_BOUND notification > sent if a driver fails to bind to a device. Extend IOMMU group > notifications to include a version of this. > > Signed-off-by: Alex Williamson > Cc: Joerg Roedel > --- > drivers/iommu/iommu.c | 2 ++ > include/linux/iommu.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 3b67144dead2..cf6051db4208 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1113,6 +1113,8 @@ static int iommu_bus_notifier(struct notifier_block *nb, > case BUS_NOTIFY_UNBOUND_DRIVER: > group_action = IOMMU_GROUP_NOTIFY_UNBOUND_DRIVER; > break; > + case BUS_NOTIFY_DRIVER_NOT_BOUND: > + group_action = IOMMU_GROUP_NOTIFY_DRIVER_NOT_BOUND; so with the break ;-) Reviewed-by: Eric Auger Thanks Eric > } > > if (group_action) > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 2e4de0deee53..54a0eb96da25 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -268,6 +268,7 @@ static inline void iommu_device_set_fwnode(struct iommu_device *iommu, > #define IOMMU_GROUP_NOTIFY_BOUND_DRIVER 4 /* Post Driver bind */ > #define IOMMU_GROUP_NOTIFY_UNBIND_DRIVER 5 /* Pre Driver unbind */ > #define IOMMU_GROUP_NOTIFY_UNBOUND_DRIVER 6 /* Post Driver unbind */ > +#define IOMMU_GROUP_NOTIFY_DRIVER_NOT_BOUND 7 /* Driver bind failed */ > > extern int bus_set_iommu(struct bus_type *bus, const struct iommu_ops *ops); > extern bool iommu_present(struct bus_type *bus); >