Re: [PATCH v4 09/30] KVM: x86: Move eager_page_split to mmu.{c,h}

[Binbin Wu <binbin.wu@linux.intel.com>]

On 6/13/2026 8:03 AM, Sean Christopherson wrote:
> Move KVM's eager_page_split module param to the MMU, as it is very much an
> MMU knob.
> 
> No functional change intended.
> 
> Reviewed-by: Kai Huang <kai.huang@intel.com>
> Reviewed-by: Yosry Ahmed <yosry@kernel.org>
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>

> ---
>  arch/x86/kvm/mmu.h     | 1 +
>  arch/x86/kvm/mmu/mmu.c | 3 +++
>  arch/x86/kvm/x86.c     | 3 ---
>  arch/x86/kvm/x86.h     | 2 --
>  4 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h
> index 0eaea2d4fac9..d30676935fff 100644
> --- a/arch/x86/kvm/mmu.h
> +++ b/arch/x86/kvm/mmu.h
> @@ -13,6 +13,7 @@ extern bool tdp_mmu_enabled;
>  #define tdp_mmu_enabled false
>  #endif
>  extern bool __read_mostly enable_mmio_caching;
> +extern bool eager_page_split;

Side topic, the attributes don't take effect for declarations, but in general,
does KVM/kernel coding style have a preference to keep it for
consistency/annotation or just drop it?