From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Bristow Subject: Re: [PATCH 12/14] KVM: x86 emulator Date: Wed, 08 Nov 2006 11:54:08 -0500 Message-ID: <1163004849.2652.1.camel@localhost.localdomain> References: <454E4941.7000108@qumranet.com> <20061107124912.GA23118@elf.ucw.cz> <4550823E.2070108@qumranet.com> <200611071412.07196.mail@earthworm.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, akpm-3NddpPZAyC0@public.gmane.org, Pavel Machek , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-reply-to: <200611071412.07196.mail-8oMOrB1mGocUSW6y5lq3GQ@public.gmane.org> To: "Hesse, Christian" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Tue, 2006-11-07 at 14:12 +0100, Hesse, Christian wrote: > On Tuesday 07 November 2006 13:55, Avi Kivity wrote: > > Pavel Machek wrote: > > >> Index: linux-2.6/drivers/kvm/x86_emulate.c > > >> =================================================================== > > >> --- /dev/null > > >> +++ linux-2.6/drivers/kvm/x86_emulate.c > > >> @@ -0,0 +1,1370 @@ > > >> +/********************************************************************** > > >>******** + * x86_emulate.c > > >> + * > > >> + * Generic x86 (32-bit and 64-bit) instruction decoder and emulator. > > >> + * > > >> + * Copyright (c) 2005 Keir Fraser > > >> + * > > >> + * Linux coding style, mod r/m decoder, segment base fixes, real-mode > > >> + * privieged instructions: > > >> + * > > >> + * Copyright (C) 2006 Qumranet > > >> + * > > >> + * Avi Kivity > > >> + * Yaniv Kamay > > >> + * > > >> + * From: xen-unstable 10676:af9809f51f81a3c43f276f00c81a52ef558afda4 > > >> + */ > > > > > > This needs GPL, I'd say. > > > Pavel > > > > The entire patchset is GPL'ed. Do you mean to make it explicit? If so, > > how? I'd rather not copy the entire license into each file. > > > > Doesn't ../../COPYING cover it, presuming it's accepted? > > I think Pavel references to these lines... > > /* > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > * the Free Software Foundation; either version 2 of the License, or > * (at your option) any later version. > * > * This program is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > * along with this program; if not, write to the Free Software > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > */ > > You should at least add a line like "This file is licensed under the terms of > the GPL v2 license (or any later version).". There is a problem with this boiler-plate that should get fixed: the FSF no longer resides at that address, they've moved. The new address is: Free Software Foundation 51 Franklin Street, Fifth Floor Boston, MA 02110-1301 USA -- David Bristow djbristow-p32f3XyCuykqcZcGjlUOXw@public.gmane.org ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642