From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: %fs PDA & KVM
Date: Mon, 12 Mar 2007 09:19:18 +1100 [thread overview]
Message-ID: <1173651559.32234.201.camel@localhost.localdomain> (raw)
In-Reply-To: <20070311122441.GA10774-X9Un+BFzKDI@public.gmane.org>
On Sun, 2007-03-11 at 13:24 +0100, Ingo Molnar wrote:
> hm, i just noticed that in vmx_vcpu_run() KVM restores %fs quite late.
>
> This is a bit awkward under v2.6.21 x86 because there we use %fs for the
> KERNEL_PDA area. Things like 'current' rely on it. So maybe we should
> just do this unconditionally in assembly:
>
> movl $(__KERNEL_PDA), %edx;
> movl %edx, %fs
Note that at some stage as Andi merges the pda->percpu conversion, this
will need to be replaced by __KERNEL_PERCPU. Trivial change.
Cheers,
Rusty.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2007-03-11 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 12:24 %fs PDA & KVM Ingo Molnar
[not found] ` <20070311122441.GA10774-X9Un+BFzKDI@public.gmane.org>
2007-03-11 12:38 ` Avi Kivity
[not found] ` <45F3F85D.7000509-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-03-11 12:41 ` Ingo Molnar
[not found] ` <20070311124146.GA15115-X9Un+BFzKDI@public.gmane.org>
2007-03-11 12:52 ` [patch] KVM: always reload segment selectors Ingo Molnar
[not found] ` <20070311125233.GA17328-X9Un+BFzKDI@public.gmane.org>
2007-03-11 13:04 ` Avi Kivity
2007-03-11 22:19 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173651559.32234.201.camel@localhost.localdomain \
--to=rusty-8n+1lvoiyb80n/f98k4iww@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox