From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: In kernel PIC support: kernel patch Date: Sat, 23 Jun 2007 00:21:14 +1000 Message-ID: <1182522074.17478.45.camel@localhost.localdomain> References: <10EA09EFD8728347A513008B6B0DA77A01A55F0A@pdsmsx411.ccr.corp.intel.com> <467BA95A.704@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <467BA95A.704-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Fri, 2007-06-22 at 13:50 +0300, Avi Kivity wrote: > Dong, Eddie wrote: > > + > > +/* set irq level. If an edge is detected, then the IRR is set to 1 */ > > > > Kernel comments like this: > > /* > * blah blah blah > */ > > This comment applies to the rest of the patch. For one-liners? Last I paid attention the main debate was about multi-line comments. Cheers, Rusty. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/