Re: [PATCH 17/20] SMP: Implement on_cpu()

Avi Kivity
2007-07-09T09:40:00Z

Andi Kleen wrote:
>> Well, smp_call_function_single() is arch specific whereas on_cpu() is
>>
>
> Yes, but the few instances should be relatively easy to fix.
>
>
>> generic code. Perhaps rename smp_call_function_single() to
>> __smp_call_function_single() and on_cpu() to smp_call_function_single()?
>>
>
> The low level function checks for this anyways. Instead of erroring
> it should just DTRT.
>

Okay. I'll make that change.

--
error compiling committee.c: too many arguments to function