Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order

Ingo Molnar
2007-07-08T12:21:37Z

* Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:

> From: Shaohua Li <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Need to flush the tlb after updating a pte, not before.

> rmap_remove(vcpu, spte);
> - kvm_flush_remote_tlbs(vcpu->kvm);
> set_shadow_pte(spte, *spte & ~PT_WRITABLE_MASK);
> + kvm_flush_remote_tlbs(vcpu->kvm);

hm, isnt this a must-have fix for v2.6.22 (and .21) as well?

Ingo