From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: "Daniel P. Berrange" <berrange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: VM id in KVM?
Date: Tue, 24 Jul 2007 08:55:55 +1000 [thread overview]
Message-ID: <1185231355.1803.22.camel@localhost.localdomain> (raw)
In-Reply-To: <20070723133234.GA31631-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Mon, 2007-07-23 at 14:32 +0100, Daniel P. Berrange wrote:
> As Avi
> says I dont't see how a individual QEMU process could provide any meaningful
> identifier itself aside from its PID whose uniqueness is guarenteed by the
> OS on its behalf.
Indeed. I use it in my pr_guest() patch which replaces all those
printks with:
+/* The guest did something wrong/strange. */
+#define pr_guest(vcpu, fmt, ...) \
+ do { \
+ if (__printk_ratelimit(5*HZ, 10)) \
+ printk(KERN_WARNING "kvm: %i: cpu%i " fmt, \
+ (vcpu)->kvm->pid, (vcpu)->vcpu_id \
+ , ## __VA_ARGS__); \
+ } while(0)
I'll polish it up and send it on. I don't want Avi getting bored.
Cheers,
Rusty.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-07-23 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 10:40 VM id in KVM? Jun Koi
[not found] ` <fdaac4d50707230340o7c2f42ecv7f22611a1e5267ee-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-23 11:05 ` Avi Kivity
[not found] ` <46A48B63.2030202-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-23 11:12 ` Carsten Otte
[not found] ` <46A48D0E.1040803-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-07-23 11:17 ` Avi Kivity
[not found] ` <46A48E65.6090105-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-23 11:19 ` Avi Kivity
[not found] ` <46A48ECD.7020809-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-23 13:32 ` Daniel P. Berrange
[not found] ` <20070723133234.GA31631-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-07-23 13:39 ` Avi Kivity
[not found] ` <46A4AF95.2070306-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-23 13:45 ` Daniel P. Berrange
2007-07-23 22:55 ` Rusty Russell [this message]
[not found] ` <1185231355.1803.22.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-24 1:44 ` Jun Koi
2007-07-24 5:17 ` Avi Kivity
[not found] ` <46A58B52.9010405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-24 5:59 ` Rusty Russell
2007-07-23 11:35 ` Carsten Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185231355.1803.22.camel@localhost.localdomain \
--to=rusty-8n+1lvoiyb80n/f98k4iww@public.gmane.org \
--cc=berrange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox