From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: [PATCH] kvm_vm_ioctl_get_dirty_log doesn't need any, probably doesn't want any Date: Mon, 30 Jul 2007 22:31:36 +1000 Message-ID: <1185798696.6131.44.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org I'm not sure what "any" was for: some optimization which got trimmed, I imagine. But neither "any" nor "i" are used later in the function, so I've excised it. Signed-off-by: Rusty Russell diff -r a17d7fe2b240 drivers/kvm/kvm_main.c --- a/drivers/kvm/kvm_main.c Mon Jul 30 15:10:22 2007 +1000 +++ b/drivers/kvm/kvm_main.c Mon Jul 30 15:20:33 2007 +1000 @@ -830,9 +830,7 @@ static int kvm_vm_ioctl_get_dirty_log(st struct kvm_dirty_log *log) { struct kvm_memory_slot *memslot; - int r, i; - int n; - unsigned long any = 0; + int r, n; spin_lock(&kvm->lock); @@ -851,11 +849,7 @@ static int kvm_vm_ioctl_get_dirty_log(st if (!memslot->dirty_bitmap) goto out; - n = ALIGN(memslot->npages, BITS_PER_LONG) / 8; - - for (i = 0; !any && i < n/sizeof(long); ++i) - any = memslot->dirty_bitmap[i]; - + n = BITS_TO_LONGS(memslot->npages) * sizeof(long); r = -EFAULT; if (copy_to_user(log->dirty_bitmap, memslot->dirty_bitmap, n)) goto out; ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/