From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [PATCH] lmsw sets lower 16 bits of cr0, not just lower 4
Date: Wed, 01 Aug 2007 10:31:48 +1000 [thread overview]
Message-ID: <1185928308.6131.116.camel@localhost.localdomain> (raw)
According to my Intel manual, although lmsw only causes an exit when
trying to set the bottom 4 bits, it is supposed to set the bottom 16
bits of cr0.
Signed-off-by: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
diff -r f06a5d7dc984 drivers/kvm/kvm_main.c
--- a/drivers/kvm/kvm_main.c Wed Jul 25 13:05:14 2007 +1000
+++ b/drivers/kvm/kvm_main.c Wed Jul 25 13:15:24 2007 +1000
@@ -526,7 +526,7 @@ EXPORT_SYMBOL_GPL(set_cr0);
void lmsw(struct kvm_vcpu *vcpu, unsigned long msw)
{
- set_cr0(vcpu, (vcpu->cr0 & ~0x0ful) | (msw & 0x0f));
+ set_cr0(vcpu, (vcpu->cr0 & ~0xffffUL) | (msw & 0xffff));
}
EXPORT_SYMBOL_GPL(lmsw);
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next reply other threads:[~2007-08-01 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 0:31 Rusty Russell [this message]
[not found] ` <1185928308.6131.116.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-08-01 18:44 ` [PATCH] lmsw sets lower 16 bits of cr0, not just lower 4 Avi Kivity
[not found] ` <46B0D4A8.7040001-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-01 23:32 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185928308.6131.116.camel@localhost.localdomain \
--to=rusty-8n+1lvoiyb80n/f98k4iww@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox