Re: [Patch] (big) real mode emulation - jmp rel

[Nitin A Kamble <nitin.a.kamble-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]

Avi,
	In my opinion converting this small function to file-scope function,
would make code look ugly. I think the earlier Macro definition was
better.


On Thu, 2007-08-16 at 03:25 -0700, Avi Kivity wrote:
> > +     inline void jmp_rel(int rel)
> > +     {
> > +             _eip += (int)(rel);
> > +             _eip = ((op_bytes == 2) ? (uint16_t)_eip :
> (uint32_t)_eip);
> > +     };
> > +
> 
> This is a nested function which we don't use (in the kernel or
> userspace).
> 
> It needs to be a file-scope function (static, too).

-- 
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel