From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/4] Rework alarm timer infrastrucure - take 2 Date: Sat, 18 Aug 2007 10:17:36 -0500 Message-ID: <1187450256.13580.1.camel@squirrel> References: <20070817231149.544849769@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org To: Luca Tettamanti Return-path: In-Reply-To: <20070817231149.544849769-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Sat, 2007-08-18 at 01:11 +0200, Luca Tettamanti wrote: > Hello, > in reply to this mail I will send a serie of 4 patches that cleans up and > expands the alarm timer handling in QEMU. Patches have been rebased on QEMU > CVS. > > Patch 1 is mostly a cleanup of the existing code; instead of having multiple > #ifdefs to handle different timers scattered all over the code I've created a > modular infrastructure where each timer type is self-contained and generic code > is more readable. The resulting code is functionally equivalent to the old one. > > Patch 2 implements the "-clock" command line option proposed by Daniel Berrange > and Avi Kivity. By default QEMU tries RTC and then falls back to unix timer; > user can override the order of the timer through this options. Syntax is pretty > simple: -clock timer1,timer2,etc. (QEMU will pick the first one that works). > > Patch 3 adds support for HPET under Linux (which is basically my old patch). As > suggested HPET takes precedence over other timers, but of course this can be > overridden. > > Patch 4 introduces "dynticks" timer source; patch is mostly based on the work > Dan Kenigsberg. dynticks is now the default alarm timer. Why do you guard dynticks with #ifdef? Is there any reason why you wouldn't want to use dynticks? Regards, Anthony Liguori > Luca ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/