public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
To: Chuan-kai Lin <cklin-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] Fix network boot whether KVM is enabled or	disabled
Date: Wed, 22 Aug 2007 19:10:22 -0500	[thread overview]
Message-ID: <1187827822.6545.1.camel@squirrel> (raw)
In-Reply-To: <135cb3c30708131022y55383d65m41b997d2c393036-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

How did you test your patch?  PXE boot hasn't ever worked with
qemu-system-x86_64.  I never dug into it because I didn't use it
(although now I do since KVM uses it by default).  I don't know that
it's worth pulling in the PXE boot fix until we figure out why it
doesn't work on qemu-system-x86_64 since KVM uses that by default now.

Regards,

Anthony Liguori


On Mon, 2007-08-13 at 10:22 -0700, Chuan-kai Lin wrote:
> On 8/13/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> > Anthony Liguori wrote:
> > > Should be:
> > > } else
> > [other indentation errors there too]
> 
> My apologies.  Webmail is probably not the best MUA for submitting
> patches in the message body.
> 
> > > I clearly preferred the way I did it but I don't care that much.  Thanks
> > > for bringing this patch up again, I've been meaning to resubmit it.
> 
> As long as PXE booting works both with and without kvm, I don't care
> which one gets included either.
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-23  0:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 22:52 [PATCH] Fix network boot whether KVM is enabled or disabled Chuan-kai Lin
     [not found] ` <135cb3c30708101552j6ed4433et5c18f2dfae9cce6d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-11  2:52   ` Anthony Liguori
     [not found]     ` <46BD2455.2040204-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-13  8:07       ` Avi Kivity
     [not found]         ` <46C0112C.6020707-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13 17:22           ` Chuan-kai Lin
     [not found]             ` <135cb3c30708131022y55383d65m41b997d2c393036-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-23  0:10               ` Anthony Liguori [this message]
2007-08-23  1:52                 ` Chuan-kai Lin
     [not found]                   ` <135cb3c30708221852v2de7377t8fefee7e18836e77-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-23  2:46                     ` Anthony Liguori
2007-08-23 19:08                       ` Chuan-kai Lin
     [not found]                         ` <135cb3c30708231208y4e2d3e87ua4bca7922bf27646-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-23 19:17                           ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187827822.6545.1.camel@squirrel \
    --to=anthony-rdkfgonbjusknkdkm+me6a@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=cklin-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox