Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c

Avi Kivity
2007-09-17T09:18:59Z

Avi Kivity wrote:
> Christoph Hellwig wrote:
>
>> On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote:
>>
>>
>>> From: Nguyen Anh Quynh <aquynh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>
>>> *nopage() in kvm_main.c should only store the type of mmap() fault if
>>> the pointers are not NULL. This patch fixes the problem.
>>>
>>>
>> Care to convert it to ->faul while you're at it?
>>
>>
>
> I'll add this to my todo, though not sure It'll be in time for .24. If
> someone sends a patch I'll apply it.
>
>

I should mention that the converting to use ->fault() is a 15-minute
change; the tricky part is adding backwards compatibility for the
external module package.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.