Re: [PATCH 1/6] virtio interace

Rusty Russell
2007-09-22T09:55:34Z

On Fri, 2007-09-21 at 16:22 +0200, Arnd Bergmann wrote:
> On Friday 21 September 2007, Rusty Russell wrote:
> > Hmm, I guess we could have a PCI driver which claims all VIRTIO vendor
> > devices.
>
> yes, that was the idea.
>
> > Then it can call virtio_find_driver() (?) at the top of its
> > probe function to find if there's a matching virtio driver.
> > This PCI driver would have to be initialized after all the virtio
> > drivers are registered, but that's easy.
>
> No, just use the driver model, instead of working against it:

But now each virtio device has two "struct device"s, not one. And
you've made up a fictional bus to do it.

Yet for PCI systems, it really is a PCI device; exposing a second bus to
userspace just because we put a layer in our implementation is poor
form.

Perhaps this is the easiest way of doing it. But it's still wrong.

Rusty.