From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerone Young Subject: Re: [PATCH] [2/2] Split arch specific makefile code out Date: Sun, 07 Oct 2007 21:03:34 -0500 Message-ID: <1191809014.6224.11.camel@laptop> References: <1191356738.15279.8.camel@laptop> <4708C81E.8090701@qumranet.com> Reply-To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: In-Reply-To: <4708C81E.8090701-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Sun, 2007-10-07 at 13:50 +0200, Avi Kivity wrote: > Jerone Young wrote: > > This patch makes things better for cross compiling. It also makes adding > > a new architecture to the current make system much easier. > > > > > +CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g -fomit-frame-pointer \ > > + -Wall > > +CFLAGS += -m32 > > +CFLAGS += -m64 Hmm.. if this is in my patch this is probably a mistake on my part. Shouldn't be adding -m32 & -m64 on the same CFLAGS. > > > > Nowhere is CFLAGS defined, that I can see. This means that a stray > CFLAGS environment variable will affect the build (this is the cause of > my dislike to ?= as well). I believe I was thinking that you might for a specific arch in config-$ARCH first declare any CFLAGS that other architectures wouldn't use. So probably a better way to do this is to have CFLAGS declaration begin at the point you describe, and then include config-$ARCH after this point. I'll submit some new patches shortly. > > Please change so that make variables cannot be affected by the environment. > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/