Re: [PATCH] Add cross compile to top level configuration file

Anthony Liguori
2007-10-16T14:59:06Z

> On Mon, 2007-10-15 at 15:13 -0500, Anthony Liguori wrote:
>
>
>>> +fi
>>> +
>>> +qemudir=`pwd`/qemu
>>> +
>>> +#configure user dir
>>> +(cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
>>> + $user_opts --arch="$arch")
>>> +(cd qemu; ./configure --target-list=$target_exec \
>>> --disable-kqemu --extra-cflags="-I $PWD/../user" \
>>> --extra-ldflags="-L $PWD/../user" \
>>> --enable-kvm --kernel-path="$libkvm_kerneldir" \
>>> - --enable-alsa \
>>> ${disable_gcc_check:+"--disable-gcc-check"} \
>>> - --prefix="$prefix"
>>> + --prefix="$prefix" \
>>> + $qemu_opts --cpu="$arch"
>>>
>>>
>> I don't think this is right. You're using two different --cpu options
>> for i386 and x86_64. There really shouldn't be a --cpu option at all
>> for x86.
>>
>
> So the --cpu option is actually a hidden option in qemu & is not on the
> qemu help page .. who know why it isn't but the it's in the code.
>
> It makes since though that if you are going to specify cross-prefix=
> then there is little reason to specify the cpu on the qemu line. As it
> should detect everything from cross compiler.
>
> I'll test this out and send a new patch with the 2 changes.
>

So, instead of doing the funky $qemu_opts thing, why not just do:

${cross_prefix:+"--cross-prefix=${cross_prefix} --cpu=${arch}"}

Regards,

Anthony Liguori