From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Cc: kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
kvm-ppc-devel
<kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [kvm-ppc-devel] [PATCH 2/3] Split kvmctl for architectures
Date: Thu, 18 Oct 2007 15:40:10 -0500 [thread overview]
Message-ID: <1192740010.21205.20.camel@basalt> (raw)
In-Reply-To: <1192739832.12849.39.camel@thinkpad>
On Thu, 2007-10-18 at 15:37 -0500, Jerone Young wrote:
> On Thu, 2007-10-18 at 15:28 -0500, Anthony Liguori wrote:
> >
> > A quick glance suggests that there's a lot of code duplication between
> > things like main-x86.c and main-ppc.c. Perhaps the common code could be
> > unified?
>
> I do have a main.c with ifdefs. But the feeling here is that as things
> are added this gets hair really quick. Right now it's ok with only 2
> main architectures. But if others come in, this file could turn into an
> ifdef mess.
>
> I really have no strong feelings on it. I can combine them.
Contrary to popular belief, we can share code between multiple
architectures without using ifdefs...
--
Hollis Blanchard
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-18 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 20:10 [PATCH 2/3] Split kvmctl for architectures Jerone Young
2007-10-18 20:28 ` Anthony Liguori
[not found] ` <4717C1E9.1050501-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-10-18 20:37 ` Jerone Young
2007-10-18 20:40 ` Hollis Blanchard [this message]
2007-10-18 20:47 ` [kvm-ppc-devel] " Jerone Young
2007-10-18 20:47 ` Izik Eidus
[not found] ` <4717C652.2060608-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-18 20:59 ` Jerone Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192740010.21205.20.camel@basalt \
--to=hollisb-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox