Re: [kvm-ppc-devel] [PATCH 2/2] Move all x86 tests to user/tests/x86

[Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

On Tue, 2007-10-23 at 10:35 -0500, Hollis Blanchard wrote:
> On Tue, 2007-10-23 at 00:57 -0500, Jerone Young wrote:
> > This patch moves all tests currently in kvm tree to a arch specific
> > directory. So files user/test/* are now in user/test/x86. These tests
> > only relate to x86. Currently this is the case. Later as these share
> > then there should be a "common" directory (tests for apic may be here).
> 
> ...
> 
> > diff --git a/user/config-x86-common.mak b/user/config-x86-common.mak
> > --- a/user/config-x86-common.mak
> > +++ b/user/config-x86-common.mak
> > @@ -11,6 +11,33 @@ libkvm.a: kvmctl.o
> > 
> >  balloon_ctl: balloon_ctl.o
> > 
> > -flatfiles-common = test/bootstrap test/vmexit.flat test/smp.flat
> > +flatfiles-common = $(TEST_DIR)/bootstrap \
> > +			$(TEST_DIR)/vmexit.flat \
> > +			$(TEST_DIR)/smp.flat
> > 
> >  flatfiles: $(flatfiles-common) $(flatfiles)
> > +
> > +$(TEST_DIR)/%.o: CFLAGS += -std=gnu99 -ffreestanding
> 
> You should be able to do something clever with $(patsubst ...) to avoid
> typing TEST_DIR everywhere.
> 
> ...
> > +
> > +arch_clean:
> > +	$(RM) $(TEST_DIR)/bootstrap $(TEST_DIR)/*.o $(TEST_DIR)/*.flat \
> > +	      $(TEST_DIR)/.*.d
> 
> I think you need a FORCE or .PHONY or whatever. (Otherwise, creating a
> file named "arch_clean" will keep this from working.)

Your right. Didn't think about that ... but also what are the chances of
a someone naming a file arch_clean? Never the less, a .PHONY is needed
I'll add that  to a separate patch, if no one has any other issues with
these patches.

> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/