From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: RFC/patch portability: split kvm_vm_ioctl v2 Date: Thu, 25 Oct 2007 11:22:02 -0500 Message-ID: <1193329322.28279.21.camel@basalt> References: <1192192452.7630.16.camel@cotte.boeblingen.de.ibm.com> <1193327325.8345.9.camel@cotte.boeblingen.de.ibm.com> <1193327326.3284.2.camel@izike-woof.qumranet.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Carsten Otte , kvm-ppc-devel , Avi Kivity , "Zhang, Xiantao" To: Izik Eidus Return-path: In-Reply-To: <1193327326.3284.2.camel-siXIhNkUrCXckEVJwWePHtCfPAL7FxvL@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, 2007-10-25 at 17:48 +0200, Izik Eidus wrote: > On Thu, 2007-10-25 at 17:48 +0200, Carsten Otte wrote: > > This patch splits kvm_vm_ioctl into archtecture independent parts, and > > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > > > Common ioctls for all architectures are: > > KVM_CREATE_VCPU, KVM_GET_DIRTY_LOG, KVM_SET_USER_MEMORY_REGION > > > > KVM_SET_USER_MEMORY_REGION is actually implemented in x86.c now, because > > the code behind looks arch specific to me. Reviewed-by: Hollis Blanchard > i think it is much better just to split the parts that allocate the > rmap, and the part that set the number of shadow pages mmu, > beside this parts it seems to me that it isnt arch specific. Carsten omitted the explanation about memslots he had in his original patch. To quote that here: > We've got a total different > address layout on s390: we cannot support multiple slots, and a user > memory range always equals the guest physical memory [guest_phys + vm > specific offset = host user address]. We don't have nor need dedicated > vmas for the guest memory, we just use what the memory managment has > in stock. This is true, because we reuse the page table for user and > guest mode. Given that explanation, and that kvm_vm_ioctl_set_memory_region() is entirely about memslots, I'm inclined to agree with this code movement. -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/