From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [kvm-ppc-devel] [PATCH 1 of 3] Move x86 kvmcallback structure tokvmctl-x86.h header Date: Sun, 28 Oct 2007 21:04:24 -0500 Message-ID: <1193623464.17368.1.camel@basalt> References: <3bf072e498768885ab96.1193618567@thinkpad> <42DFA526FC41B1429CE7279EF83C6BDC8B51E0@pdsmsx415.ccr.corp.intel.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC8B51E0-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Mon, 2007-10-29 at 09:13 +0800, Zhang, Xiantao wrote: > Jerone Young wrote: > > # HG changeset patch > > # User Jerone Young > > # Date 1193618330 18000 > > # Node ID 3bf072e498768885ab96b7ccb668b61c96db0e83 > > # Parent a6f7c585fe76f9563fd061cfe3e772532ab27952 > > Move x86 kvmcallback structure to kvmctl-x86.h header. > > > > This patch moves the kvmcallback structure that is currently in > > kvmctl.h into an arch specific header. > > > > Signed-off-by: Jerone Young > > > > new file mode 100644 > > > > diff --git a/user/kvmctl-x86.h b/user/kvmctl-x86.h > > new file mode 100644 > > --- /dev/null > > +++ b/user/kvmctl-x86.h > > @@ -0,0 +1,54 @@ > > +#ifndef KVMCTL_X86_H > > +#define KVMCTL_X86_H > > + > > +/*! > > + * \brief KVM callbacks structure > > + * > > + * This structure holds pointers to various functions that KVM will > > call + * when it encounters something that cannot be virtualized, > > such as + * accessing hardware devices via MMIO or regular IO. > > + */ > > +struct kvm_callbacks { > > + /// For 8bit IO reads from the guest (Usually when executing > 'inb') > > + int (*inb)(void *opaque, uint16_t addr, uint8_t *data); > > + /// For 16bit IO reads from the guest (Usually when executing > 'inw') > > + int (*inw)(void *opaque, uint16_t addr, uint16_t *data); > > I don't know the privious story about this thread, but now I can't > understand the move. Why do we move all the structure to arch-specific ? > For IA64 side, almostly we can reuse them directly, and just see some > special fields as arch-specific. So, I think, we should keep common > fields in kvmctl.h. Are you suggesting that kvm_callbacks should be the union of all callbacks used on all architectures, and for any given architecture only a subset are actually used? -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/