Re: [Patch][RFC] fix make rpm

[Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

On Wed, 2007-10-31 at 02:39 +0200, Avi Kivity wrote:
> Hollis Blanchard wrote:
> > On Tue, 2007-10-30 at 13:59 +0200, Avi Kivity wrote:
> >   
> >>> -/usr/kvm
> >>> +%dir /usr/kvm
> >>> +%dir /usr/kvm/bin
> >>> +/usr/kvm/bin/qemu-img
> >>> +/usr/kvm/bin/qemu-system-x86_64
> >>>       
> > [...]
> >   
> >> Why is this change necessary?  Doesn't '/usr/kvm' work?  This way,
> >> every time qemu adds a file we have to update the rpm spec.
> >>     
> >
> > FYI, I got burned by exactly this problem once. Due to a missing prereq,
> > a package build didn't produce all the output it should have. However,
> > because I hadn't listed every output explicitly, rpm happily packaged
> > everything else, and the package shipped in a distro before anybody
> > realized anything was missing.
> >
> >   
> 
> Yeah, perhaps the script should have a "dangerous" label.  Or all rpm 
> scripts.
> 
> Listing the files doesn't actually solve the problem.  How does a 
> packager know if a file was removed intenrionally or accidentally?

When the package won't build due to a missing file, that draws
attention, and so the packager investigates (and sees for example that
the file in question is no longer listed in any Makefiles).

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/