Re: RFC/patch 2/3 portability: move x86 emulation and mmio device hook to x86.c

Hollis Blanchard
2007-10-30T18:12:39Z

On Tue, 2007-10-30 at 18:44 +0100, Carsten Otte wrote:
>
> -/*
> - * Only apic need an MMIO device hook, so shortcut now..
> - */
> -static struct kvm_io_device *vcpu_find_pervcpu_dev(struct kvm_vcpu *vcpu,
> - gpa_t addr)
> -{
> - struct kvm_io_device *dev;
> -
> - if (vcpu->apic) {
> - dev = &vcpu->apic->dev;
> - if (dev->in_range(dev, addr))
> - return dev;
> - }
> - return NULL;
> -}
> -
> -static struct kvm_io_device *vcpu_find_mmio_dev(struct kvm_vcpu *vcpu,
> - gpa_t addr)
> -{
> - struct kvm_io_device *dev;
> -
> - dev = vcpu_find_pervcpu_dev(vcpu, addr);
> - if (dev == NULL)
> - dev = kvm_io_bus_find_dev(&vcpu->kvm->mmio_bus, addr);
> - return dev;
> -}
> -
> static struct kvm_io_device *vcpu_find_pio_dev(struct kvm_vcpu *vcpu,
> gpa_t addr)
> {
> return kvm_io_bus_find_dev(&vcpu->kvm->pio_bus, addr);
> }

These are APIC-specific for now, but as the "shortcut" comment implies
they should be generalized in the future, and I expect they will be
useful for PowerPC.

I'm fine with the patch as-is; I just want to point out that future work
will be needed in this area.

Acked-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

--
Hollis Blanchard
IBM Linux Technology Center