From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [kvm-ppc-devel] [PATCH 02 of 19] Make static slot & kvm_memory region funcions public Date: Fri, 02 Nov 2007 14:36:25 -0500 Message-ID: <1194032185.6479.75.camel@basalt> References: <17bf778405bb2aea7eab.1194027891@thinkpad> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jerone Young Return-path: In-Reply-To: <17bf778405bb2aea7eab.1194027891@thinkpad> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Fri, 2007-11-02 at 13:24 -0500, Jerone Young wrote: > diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c > --- a/libkvm/libkvm.c > +++ b/libkvm/libkvm.c > @@ -46,7 +46,7 @@ int free_slots[KVM_MAX_NUM_MEM_REGIONS]; > int free_slots[KVM_MAX_NUM_MEM_REGIONS]; > unsigned long phys_addr_slots[KVM_MAX_NUM_MEM_REGIONS]; > > -static void init_slots() > +void init_slots() > { > int i; As long as you're here could you please add a "void"? That bugs me every time I see it. -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/