From: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Carlo Marcelo Arenas Belon
<carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] make msrs functions public for x86
Date: Thu, 08 Nov 2007 11:10:57 -0600 [thread overview]
Message-ID: <1194541857.13920.2.camel@thinkpad> (raw)
In-Reply-To: <20071108063437.GB1937@tapir>
This would be my bad. Things kept changing and I didn't put these back
into libkvm.h.
On Thu, 2007-11-08 at 00:34 -0600, Carlo Marcelo Arenas Belon wrote:
> This patch partially reverts 9105435f46ca4e110237eae57272e4f5deaf8dd6 so that
> kvm_msr_list, kvm_get_msrs and kvm_set_msrs are again public and visible in
> userspace for x86 as they are used by qemu-kvm
>
> Signed-off-by: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
> ---
> libkvm/kvm-x86.h | 4 ----
> libkvm/libkvm.h | 6 ++++++
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/libkvm/kvm-x86.h b/libkvm/kvm-x86.h
> index b531a3b..bcc6981 100644
> --- a/libkvm/kvm-x86.h
> +++ b/libkvm/kvm-x86.h
> @@ -42,8 +42,4 @@ int kvm_run_abi10(kvm_context_t kvm, int vcpu);
>
> void kvm_show_code(kvm_context_t kvm, int vcpu);
>
> -struct kvm_msr_list *kvm_get_msr_list(kvm_context_t);
> -int kvm_get_msrs(kvm_context_t, int vcpu, struct kvm_msr_entry *msrs, int n);
> -int kvm_set_msrs(kvm_context_t, int vcpu, struct kvm_msr_entry *msrs, int n);
> -
> #endif
> diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h
> index b00d658..8a41df7 100644
> --- a/libkvm/libkvm.h
> +++ b/libkvm/libkvm.h
> @@ -19,6 +19,12 @@ struct kvm_context;
>
> typedef struct kvm_context *kvm_context_t;
>
> +#if defined(__x86_64__) || defined(__i386__)
> +struct kvm_msr_list *kvm_get_msr_list(kvm_context_t);
> +int kvm_get_msrs(kvm_context_t, int vcpu, struct kvm_msr_entry *msrs, int n);
> +int kvm_set_msrs(kvm_context_t, int vcpu, struct kvm_msr_entry *msrs, int n);
> +#endif
> +
> /*!
> * \brief KVM callbacks structure
> *
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-11-08 17:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 16:48 [PATCH 00 of 17] [v4] libkvm refactor Jerone Young
2007-11-06 16:48 ` [PATCH 01 of 17] Move kvm_context to kvm-common.h & add CFLAGS to config-* filese Jerone Young
2007-11-06 16:48 ` [PATCH 02 of 17] Make static slot & kvm_memory region funcions public Jerone Young
2007-11-06 16:48 ` [PATCH 03 of 17] Move fuction kvm_alloc_kernel_memory to libkvm-x86.c Jerone Young
2007-11-06 16:48 ` [PATCH 04 of 17] Move kvm_alloc_userspace_memory " Jerone Young
2007-11-06 16:48 ` [PATCH 05 of 17] Modify out arch specific code from kvm_create function Jerone Young
2007-11-06 16:48 ` [PATCH 06 of 17] Move kvm_create_kernel_phys_mem to libkvm-x86.c Jerone Young
2007-11-06 16:48 ` [PATCH 07 of 17] Move kvm_create_memory_alias & kvm_destroy_memory_alias " Jerone Young
2007-11-07 13:52 ` Avi Kivity
2007-11-06 16:48 ` [PATCH 08 of 17] Move kvm_get & kmv_set_lapci functions " Jerone Young
2007-11-06 16:48 ` [PATCH 09 of 17] Make functions in libkvm.c nonstatic Jerone Young
2007-11-06 16:48 ` [PATCH 10 of 17] Move abi 10 functions to libkvm-x86.c Jerone Young
2007-11-06 16:48 ` [PATCH 11 of 17] Move msrs " Jerone Young
2007-11-08 5:57 ` Carlo Marcelo Arenas Belon
2007-11-08 5:54 ` Avi Kivity
[not found] ` <4732A4AE.30100-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-08 6:34 ` [PATCH] make msrs functions public for x86 Carlo Marcelo Arenas Belon
2007-11-08 8:30 ` Avi Kivity
2007-11-08 17:10 ` Jerone Young [this message]
2007-11-08 18:59 ` [PATCH 11 of 17] Move msrs functions to libkvm-x86.c Hollis Blanchard
2007-11-11 10:01 ` Avi Kivity
2007-11-06 16:48 ` [PATCH 12 of 17] Move print_seg & Move kvm_show_regs " Jerone Young
2007-11-06 16:48 ` [PATCH 13 of 17] Declare kvm_abi as a global variable in kvm-common.h Jerone Young
2007-11-06 16:48 ` [PATCH 14 of 17] Move kvm_get_apic to libkvm-x86.c Jerone Young
2007-11-06 16:48 ` [PATCH 15 of 17] Move cr8 functions " Jerone Young
2007-11-06 16:48 ` [PATCH 16 of 17] Move kvm_setup_cpuid " Jerone Young
2007-11-06 16:48 ` [PATCH 17 of 17] Remove unsued inclusion of linux/kvm_parah.h in userspace libkvm.h Jerone Young
2007-11-07 13:52 ` [PATCH 00 of 17] [v4] libkvm refactor Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194541857.13920.2.camel@thinkpad \
--to=jyoung5-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox