From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH 11 of 17] Move msrs functions to libkvm-x86.c Date: Thu, 08 Nov 2007 12:59:52 -0600 Message-ID: <1194548392.22879.14.camel@basalt> References: <20071108055700.GA1937@tapir> <4732A4AE.30100@qumranet.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young , Carlo Marcelo Arenas Belon To: Avi Kivity Return-path: In-Reply-To: <4732A4AE.30100-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, 2007-11-08 at 07:54 +0200, Avi Kivity wrote: > Carlo Marcelo Arenas Belon wrote: > > On Tue, Nov 06, 2007 at 10:48:52AM -0600, Jerone Young wrote: > > > >> Move msrs functions to libkvm-x86.c > >> > >> This patch moves functions: > >> kvm_msr_list > >> move kvm_get_msrs > >> move kvm_set_msrs > >> > > > > the problem is that with this the definitions were moved as well from libkvm.h > > to kvm-x86.h which is private and not meant to be exported outside of libkvm > > but those 3 functions are used by qemu-kvm.c as shown by : > > > > > > They need to be moved back to libkvm.h with a #ifdef. And to the #ifdef > purists I say: deorbit. Re-entry is looking rough; things are much better up here. ;) Anyways, you don't need to ifdef a prototype; just don't call it. Also, naming them kvm_x86_get_msrs() and kvm_x86_set_msrs() would be a much better warning sign for callers. -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/