From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: 2.6.23 git current compile error on UP Date: Thu, 08 Nov 2007 11:55:49 -0800 Message-ID: <1194551749.7078.78.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "linux-kernel@vger.kernel.org" , kvm-devel , aliguori To: Laurent Vivier Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org drivers/kvm/kvm_main.c: In function `kvm_flush_remote_tlbs': drivers/kvm/kvm_main.c:220: error: implicit declaration of function `smp_call_function_mask' make[2]: *** [drivers/kvm/kvm_main.o] Error 1 make[1]: *** [drivers/kvm] Error 2 http://sr71.net/~dave/linux/config-kvm-up Looks like that function calls smp_call_function_mask() which is never defined for UP. Nobody else uses it that way, so I'm not sure what the right fix is. I'm not even sure kvm_flush_remote_tlbs() is safe with its raw_smp_processor_id() use. Is there a reason it can't get preempted? -- Dave