2.6.23 git current compile error on UP

2.6.23 git current compile error on UP

[Dave Hansen]

drivers/kvm/kvm_main.c: In function `kvm_flush_remote_tlbs':
drivers/kvm/kvm_main.c:220: error: implicit declaration of function `smp_call_function_mask'
make[2]: *** [drivers/kvm/kvm_main.o] Error 1
make[1]: *** [drivers/kvm] Error 2

http://sr71.net/~dave/linux/config-kvm-up

Looks like that function calls smp_call_function_mask() which is never
defined for UP.  Nobody else uses it that way, so I'm not sure what the
right fix is.  I'm not even sure kvm_flush_remote_tlbs() is safe with
its raw_smp_processor_id() use.  Is there a reason it can't get
preempted?

-- Dave

Re: 2.6.23 git current compile error on UP

[Laurent Vivier]

[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]

Le jeudi 08 novembre 2007 à 11:55 -0800, Dave Hansen a écrit :
> drivers/kvm/kvm_main.c: In function `kvm_flush_remote_tlbs':
> drivers/kvm/kvm_main.c:220: error: implicit declaration of function `smp_call_function_mask'
> make[2]: *** [drivers/kvm/kvm_main.o] Error 1
> make[1]: *** [drivers/kvm] Error 2
> 
> http://sr71.net/~dave/linux/config-kvm-up
> 
> Looks like that function calls smp_call_function_mask() which is never
> defined for UP.  Nobody else uses it that way, so I'm not sure what the
> right fix is.  I'm not even sure kvm_flush_remote_tlbs() is safe with
> its raw_smp_processor_id() use.  Is there a reason it can't get
> preempted?

Avi has already posted a patch to correct this.

http://lkml.org/lkml/2007/10/24/95

Laurent

[-- Attachment #1.2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel