From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH]3/5 Using kvm_arch prefix to define functions, and replace Date: Thu, 08 Nov 2007 14:57:41 -0600 Message-ID: <1194555461.22879.39.camel@basalt> References: <42DFA526FC41B1429CE7279EF83C6BDC905005@pdsmsx415.ccr.corp.intel.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, Avi Kivity To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC905005-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, 2007-11-08 at 15:21 +0800, Zhang, Xiantao wrote: > @@ -890,7 +890,7 @@ static int kvm_vm_ioctl_create_vcpu(struct kvm > *kvm, > int n) > if (!valid_vcpu(n)) > return -EINVAL; > > - vcpu = kvm_x86_ops->vcpu_create(kvm, n); > + vcpu = kvm_arch_vcpu_create(kvm, n); > if (IS_ERR(vcpu)) > return PTR_ERR(vcpu); > > @@ -900,7 +900,7 @@ static int kvm_vm_ioctl_create_vcpu(struct kvm > *kvm, > int n) > BUG_ON((unsigned long)&vcpu->host_fx_image & 0xF); > > vcpu_load(vcpu); > - r = kvm_x86_ops->vcpu_reset(vcpu); > + r = kvm_arch_vcpu_reset(vcpu); > if (r == 0) > r = kvm_mmu_setup(vcpu); > vcpu_put(vcpu); > @@ -933,7 +933,7 @@ mmu_unload: > vcpu_put(vcpu); > > free_vcpu: > - kvm_x86_ops->vcpu_free(vcpu); > + kvm_arch_vcpu_free(vcpu); > return r; > } Have a look at the patch I posted on Wednesday: "[PATCH 2 of 2] RFC: Create kvm_arch_vcpu_create()". kvm_arch_vcpu_create() will actually encompass more logic from kvm_vm_ioctl_create_vcpu(), and once you do that, kvm_arch_vcpu_reset() doesn't need to exist (which will also make Carsten happy). -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/