From: Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: zach-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
lguest-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
ak-l3A5Bk7waGM@public.gmane.org,
avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org,
virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
Glauber de Oliveira Costa
<gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 22/24] prepare x86_64 architecture initialization for paravirt
Date: Fri, 9 Nov 2007 16:43:03 -0200 [thread overview]
Message-ID: <11946339033567-git-send-email-gcosta@redhat.com> (raw)
In-Reply-To: <1194633898545-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
This patch prepares the x86_64 architecture initialization for
paravirt. It requires a memory initialization step, which is done
by implementing 64-bit version for machine_specific_memory_setup,
and putting an ARCH_SETUP hook, for guest-dependent initialization.
This last step is done akin to i386
Signed-off-by: Glauber de Oliveira Costa <gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
Acked-by: Jeremy Fitzhardinge <jeremy-8XJ3FbD+ij9l57MIdRCFDg@public.gmane.org>
---
arch/x86/kernel/e820_64.c | 9 +++++++--
arch/x86/kernel/setup_64.c | 28 +++++++++++++++++++++++++++-
include/asm-x86/setup.h | 11 ++++++++---
3 files changed, 42 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/e820_64.c b/arch/x86/kernel/e820_64.c
index 0128b0b..eed900b 100644
--- a/arch/x86/kernel/e820_64.c
+++ b/arch/x86/kernel/e820_64.c
@@ -639,8 +639,10 @@ void early_panic(char *msg)
panic(msg);
}
-void __init setup_memory_region(void)
+/* We're not void only for x86 32-bit compat */
+char * __init machine_specific_memory_setup(void)
{
+ char *who = "BIOS-e820";
/*
* Try to copy the BIOS-supplied E820-map.
*
@@ -651,7 +653,10 @@ void __init setup_memory_region(void)
if (copy_e820_map(boot_params.e820_map, boot_params.e820_entries) < 0)
early_panic("Cannot find a valid memory map");
printk(KERN_INFO "BIOS-provided physical RAM map:\n");
- e820_print_map("BIOS-e820");
+ e820_print_map(who);
+
+ /* In case someone cares... */
+ return who;
}
static int __init parse_memopt(char *p)
diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c
index 2451a63..1c9f237 100644
--- a/arch/x86/kernel/setup_64.c
+++ b/arch/x86/kernel/setup_64.c
@@ -39,6 +39,7 @@
#include <linux/dmi.h>
#include <linux/dma-mapping.h>
#include <linux/ctype.h>
+#include <linux/uaccess.h>
#include <asm/mtrr.h>
#include <asm/uaccess.h>
@@ -61,6 +62,12 @@
#include <asm/cacheflush.h>
#include <asm/mce.h>
+#ifdef CONFIG_PARAVIRT
+#include <asm/paravirt.h>
+#else
+#define ARCH_SETUP
+#endif
+
/*
* Machine setup..
*/
@@ -244,6 +251,16 @@ static void discover_ebda(void)
* 4K EBDA area at 0x40E
*/
ebda_addr = *(unsigned short *)__va(EBDA_ADDR_POINTER);
+ /*
+ * There can be some situations, like paravirtualized guests,
+ * in which there is no available ebda information. In such
+ * case, just skip it
+ */
+ if (!ebda_addr) {
+ ebda_size = 0;
+ return;
+ }
+
ebda_addr <<= 4;
ebda_size = *(unsigned short *)__va(ebda_addr);
@@ -257,6 +274,12 @@ static void discover_ebda(void)
ebda_size = 64*1024;
}
+/* Overridden in paravirt.c if CONFIG_PARAVIRT */
+void __attribute__((weak)) memory_setup(void)
+{
+ machine_specific_memory_setup();
+}
+
void __init setup_arch(char **cmdline_p)
{
printk(KERN_INFO "Command line: %s\n", boot_command_line);
@@ -272,7 +295,10 @@ void __init setup_arch(char **cmdline_p)
rd_prompt = ((boot_params.hdr.ram_size & RAMDISK_PROMPT_FLAG) != 0);
rd_doload = ((boot_params.hdr.ram_size & RAMDISK_LOAD_FLAG) != 0);
#endif
- setup_memory_region();
+
+ ARCH_SETUP
+
+ memory_setup();
copy_edd();
if (!boot_params.hdr.root_flags)
diff --git a/include/asm-x86/setup.h b/include/asm-x86/setup.h
index 24d786e..071e054 100644
--- a/include/asm-x86/setup.h
+++ b/include/asm-x86/setup.h
@@ -3,6 +3,13 @@
#define COMMAND_LINE_SIZE 2048
+#ifndef __ASSEMBLY__
+char *machine_specific_memory_setup(void);
+#ifndef CONFIG_PARAVIRT
+#define paravirt_post_allocator_init() do {} while (0)
+#endif
+#endif /* __ASSEMBLY__ */
+
#ifdef __KERNEL__
#ifdef __i386__
@@ -51,9 +58,7 @@ void __init add_memory_region(unsigned long long start,
extern unsigned long init_pg_tables_end;
-#ifndef CONFIG_PARAVIRT
-#define paravirt_post_allocator_init() do {} while (0)
-#endif
+
#endif /* __i386__ */
#endif /* _SETUP */
--
1.4.4.2
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-11-09 18:43 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 18:42 [PATCH 0/24] paravirt_ops for unified x86 - that's me again! Glauber de Oliveira Costa
[not found] ` <11946337851964-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included Glauber de Oliveira Costa
[not found] ` <11946337933104-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 2/24] irqflags consolidation Glauber de Oliveira Costa
[not found] ` <11946337991750-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 3/24] consolidate spinlock.h Glauber de Oliveira Costa
[not found] ` <11946338053158-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 4/24] tlb functions consolidation Glauber de Oliveira Costa
[not found] ` <11946338103068-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 5/24] smp x86 consolidation Glauber de Oliveira Costa
2007-11-09 18:42 ` [PATCH 6/24] Add debugreg/load_rsp native hooks Glauber de Oliveira Costa
[not found] ` <11946338212915-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 7/24] consolidate msr.h Glauber de Oliveira Costa
[not found] ` <11946338263902-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 8/24] consolidate system.h Glauber de Oliveira Costa
[not found] ` <1194633831882-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 9/24] Wipe out traditional opt from x86_64 Makefile Glauber de Oliveira Costa
[not found] ` <11946338361369-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 10/24] paravirt hooks at entry functions Glauber de Oliveira Costa
[not found] ` <11946338413283-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 11/24] read/write_crX, clts and wbinvd for 64-bit paravirt Glauber de Oliveira Costa
[not found] ` <11946338473652-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 12/24] provide native irq initialization function Glauber de Oliveira Costa
[not found] ` <1194633852469-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 13/24] report ring kernel is running without paravirt Glauber de Oliveira Costa
[not found] ` <1194633857930-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 14/24] export math_state_restore Glauber de Oliveira Costa
[not found] ` <11946338621966-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 15/24] native versions for set pagetables Glauber de Oliveira Costa
[not found] ` <11946338683305-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 16/24] add native functions for descriptors handling Glauber de Oliveira Costa
[not found] ` <1194633873306-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 17/24] This patch add provisions for time related functions so they Glauber de Oliveira Costa
[not found] ` <1194633878886-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:42 ` [PATCH 18/24] export cpu_gdt_descr Glauber de Oliveira Costa
[not found] ` <11946338832681-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:43 ` [PATCH 19/24] turn priviled operation into a macro in head_64.S Glauber de Oliveira Costa
[not found] ` <1194633888761-git-send-email-gco! sta@redhat.com>
[not found] ` <1194633888761-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:43 ` [PATCH 20/24] tweak io_64.h for paravirt Glauber de Oliveira Costa
[not found] ` <11946338932611-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:43 ` [PATCH 21/24] native versions for page table entries values Glauber de Oliveira Costa
[not found] ` <1194633898545-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:43 ` Glauber de Oliveira Costa [this message]
[not found] ` <11946339033567-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:43 ` [PATCH 23/24] consolidation of paravirt for 32 and 64 bits Glauber de Oliveira Costa
[not found] ` <11946339082711-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-09 18:43 ` [PATCH 24/24] make vsmp a paravirt client Glauber de Oliveira Costa
[not found] ` <11946339142999-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-11 18:07 ` Andi Kleen
[not found] ` <20071111180709.GG22277-KvMlXPVkKihbpigZmTR7Iw@public.gmane.org>
2007-11-13 11:36 ` Glauber de Oliveira Costa
[not found] ` <47398C4A.40806-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-13 12:33 ` Andi Kleen
[not found] ` <200711131333.41946.ak-l3A5Bk7waGM@public.gmane.org>
2007-11-13 12:51 ` Glauber de Oliveira Costa
[not found] ` <47399DC8.7000504-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-13 13:09 ` Andi Kleen
[not found] ` <200711131409.41959.ak-l3A5Bk7waGM@public.gmane.org>
2007-11-13 18:49 ` Ravikiran Thirumalai
2007-11-13 17:21 ` Jeremy Fitzhardinge
2007-11-13 18:00 ` Ravikiran Thirumalai
2007-11-19 22:21 ` [PATCH 7/24] consolidate msr.h Bastian Blank
2007-11-19 22:36 ` Steven Rostedt
[not found] ` <Pine.LNX.4.58.0711191734270.32296-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2007-11-20 5:51 ` Ingo Molnar
[not found] ` <20071120055113.GC20436-X9Un+BFzKDI@public.gmane.org>
2007-11-20 6:14 ` Steven Rostedt
2007-11-20 6:16 ` Steven Rostedt
[not found] ` <Pine.LNX.4.58.0711200114580.4062-f9ZlEuEWxVcI6MkJdU+c8EEOCMrvLtNR@public.gmane.org>
2007-11-20 10:43 ` Rusty Russell
[not found] ` <1194633815833-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-10 0:29 ` [PATCH 5/24] smp x86 consolidation Jeremy Fitzhardinge
[not found] ` <4734FB67.8080500-TSDbQ3PG+2Y@public.gmane.org>
2007-11-10 1:29 ` Glauber de Oliveira Costa
[not found] ` <4735098B.7040305-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-10 2:08 ` Jeremy Fitzhardinge
2007-11-17 9:32 ` Ingo Molnar
2007-11-09 23:00 ` [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included Jeremy Fitzhardinge
[not found] ` <4734E6A0.6070508-TSDbQ3PG+2Y@public.gmane.org>
2007-11-10 1:26 ` Glauber de Oliveira Costa
2007-11-12 8:17 ` [PATCH 0/24] paravirt_ops for unified x86 - that's me again! Amit Shah
[not found] ` <200711121347.20050.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-13 11:43 ` Glauber de Oliveira Costa
2007-11-13 20:26 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11946339033567-git-send-email-gcosta@redhat.com \
--to=gcosta-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=ak-l3A5Bk7waGM@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=lguest-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=zach-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox