Re: [PATCH][RFC] Struct kvm split

[Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

On Mon, 2007-11-19 at 18:05 +0800, Zhang, Xiantao wrote:
> Hi Avi,
> Based on privious discussion,  I made this patch to split struct kvm.
> In this patch, strcut kvm only holds common fields, and struct kvm_x86
> will keep x86-specific fields.  In this way, struct kvm will be a
> sub-filed in struct kvm_x86, and we can use to_kvm_x86 to get kvm_x86
> from struct kvm.  It is very similar with current to_vmx approach for
> getting struct vmx from struct kvm_vcpu.    This is a rough split based
> on this idea.  Any comments are welcome! 

I was very confused until I realized you're only dealing with struct
kvm, not struct kvm_vcpu. I actually started the kvm_vcpu work last
week, and it is a much larger patch. :)

Some whitespace sloppiness (e.g. "struct kvm_x86{", extra blank lines in
a few places, and I'm worried about 80 columns in a few places).

Some of the fields you've left common (e.g. apic_access_page, mmio_bus,
pio_bus) should be moved, but if this split works for IA64 then it's
fine to leave those changes for other architectures.

In general I like it.

Acked-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/