From mboxrd@z Thu Jan  1 00:00:00 1970
From: Izik Eidus <izike-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] Moving unalias_gfn to x86.c
Date: Thu, 22 Nov 2007 11:03:49 +0200
Message-ID: <1195722229.12454.1.camel@localhost.localdomain>
References: <42DFA526FC41B1429CE7279EF83C6BDC9E733B@pdsmsx415.ccr.corp.intel.com>
	<1195720902.3438.5.camel@localhost.localdomain>
	<42DFA526FC41B1429CE7279EF83C6BDC9E74BE@pdsmsx415.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
	Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>, Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: "Zhang, Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC9E74BE-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
List-Help: <mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=subscribe>
Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
List-Id: kvm.vger.kernel.org


On Thu, 2007-11-22 at 17:09 +0800, Zhang, Xiantao wrote:
> Izik Eidus wrote:
> > On Thu, 2007-11-22 at 11:25 +0800, Zhang, Xiantao wrote:
> >> From: Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >> Date: Thu, 22 Nov 2007 11:20:33 +0800
> >> Subject: [PATCH] KVM Portability: moving unalias_gfn to arch.
> >> Non-x86 archs don't need this mechanism. Move it to arch, and keep
> >> its interface in common. Signed-off-by: Zhang Xiantao
> >> <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> ---
> > 
> > this is good,
> > 
> > we probably want to change
> > gfn_to_memslot() to have #ifdef kvm_x86 to call the unalias memory
> > and gfn_to_hva on x86 still must to call unalias_gfn() so it will
> > probably need a ifdef as well.
> 
> Don't know #ifdef way is acceptable. If yes, sure to do that.
> Contrarily, other archs
> can define it , and just returen original gfn instead:)
> 
ok so call to kvm_arch_gfn_to_memslot()
or something like that can be done
the same with
kvm_arch_gva_to_hva()

this both will call to kvm_gva_to_hva() that will share most of the code
...


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/