Re: [PATCH] Add ifdef in irqchip struct for x86 only structures

Jerone Young
2007-11-26T16:13:28Z

Hmm... so now begins the conflict with userspace and kernel space header
sharing ;-)

So the issue (which can be easily fixed) is that CONFIG_X86 is not
recognized in any userspace apps. While __i386__ & __x86_64__ are. Now
this can easily be added to our build system. But it does show the
problem.

Also there are other headers in include/linux that use the same if
defined method that I used (actually checked to see if anyone had done
it in there).

On Mon, 2007-11-26 at 17:19 +0200, Avi Kivity wrote:
> Jerone Young wrote:
> > # HG changeset patch
> > # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > # Date 1196087575 21600
> > # Node ID ccf9dd8a8e0a4513090d44d52c879fb9dfbb79dd
> > # Parent 32d8bd91d9441d2a3655593a0aaf99f6c403d70f
> > Add ifdef in irqchip struct for x86 only structures.
> >
> > This patch fixes a small issue where sturctures:
> > kvm_pic_state
> > kvm_ioapic_state
> >
> > are defined inside x86 specific code and may or may not
> > be defined in anyway for other architectures. The problem
> > caused is one cannot compile userspace apps (ex. libkvm)
> > for other archs since a size cannot be determined for these
> > structures.
> >
> >
> Applied, but changed
>
> > +#if defined(__i386__) || defined(__x86_64__)
> >
>
> to
>
> #ifdef CONFIG_X86
>
> .