From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Goldish Subject: Re: [KVM_AUTOTEST] add kvm hugepage variant and test Date: Thu, 9 Jul 2009 08:30:12 -0400 (EDT) Message-ID: <119650285.208601247142612126.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> References: <4A55B759.5080302@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: KVM list , Jason Wang To: =?utf-8?Q?Luk=C3=A1=C5=A1_Doktor?= Return-path: Received: from mx1.redhat.com ([66.187.233.31]:51520 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756117AbZGIMaV convert rfc822-to-8bit (ORCPT ); Thu, 9 Jul 2009 08:30:21 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n69CUKs8007198 for ; Thu, 9 Jul 2009 08:30:20 -0400 In-Reply-To: <4A55B759.5080302@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: I don't think you need to explicitly check for a memory allocation failure in VM.create() ("qemu produced some output ..."). VM.create() already makes sure the VM is started successfully, and prints informative failure messages if there's any problem. ----- "Luk=C3=A1=C5=A1 Doktor" wrote: > This patch adds kvm_hugepage variant. It prepares the host system and > start vm with -mem-path option. It does not clean after itself, > because=20 > it's impossible to unmount and free hugepages before all guests are=20 > destroyed. >=20 > There is also added autotest.libhugetlbfs test. >=20 > I need to ask you what to do with change of qemu parameter. Newest=20 > versions are using -mempath insted of -mem-path. This is impossible t= o > fix using current config file. I can see 2 solutions: > 1) direct change in kvm_vm.py (parse output and try another param) > 2) detect qemu capabilities outside and create additional layer > (better=20 > for future occurrence) I'll have to think about this a little before answering. > Tested by:ldoktor@redhat.com on RHEL5.4 with kvm-83-72.el5