From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [kvm-ppc-devel] [PATCH 2 of 3] Move IO device definitions to its own header file
Date: Tue, 04 Dec 2007 08:58:35 -0600 [thread overview]
Message-ID: <1196780315.7475.1.camel@basalt> (raw)
In-Reply-To: <4755590F.60301-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
On Tue, 2007-12-04 at 14:41 +0100, Carsten Otte wrote:
> Hollis Blanchard wrote:
> > diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
> > --- a/drivers/kvm/kvm_main.c
> > +++ b/drivers/kvm/kvm_main.c
> > @@ -18,6 +18,7 @@
> > #include "kvm.h"
> > #include "x86.h"
> > #include "irq.h"
> > +#include "iodev.h"
> >
> > #include <linux/kvm.h>
> > #include <linux/module.h>
> Why do we have that include in kvm_main? I will need to get rid of it
> for s390 later on.
Just because of the call to kvm_iodevice_destructor(). I would be happy
to see kvm_io_bus_* moved out to its own files as well, which would
solve this issue.
--
Hollis Blanchard
IBM Linux Technology Center
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
next prev parent reply other threads:[~2007-12-04 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 21:30 [PATCH 0 of 3] Portability: allow for non-x86 headers Hollis Blanchard
2007-12-03 21:30 ` [PATCH 1 of 3] Move address types to their own header file Hollis Blanchard
2007-12-04 13:35 ` Carsten Otte
2007-12-03 21:30 ` [PATCH 2 of 3] Move IO device definitions to its " Hollis Blanchard
2007-12-04 13:41 ` Carsten Otte
[not found] ` <4755590F.60301-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-12-04 14:58 ` Hollis Blanchard [this message]
2007-12-03 21:30 ` [PATCH 3 of 3] Stop including x86-specific headers in kvm_main.c Hollis Blanchard
2007-12-04 13:37 ` Carsten Otte
2007-12-05 10:14 ` [PATCH 0 of 3] Portability: allow for non-x86 headers Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196780315.7475.1.camel@basalt \
--to=hollisb-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox