From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [kvm-ppc-devel] [PATCH 2 of 3] Move IO device definitions to its own header file Date: Tue, 04 Dec 2007 08:58:35 -0600 Message-ID: <1196780315.7475.1.camel@basalt> References: <4755590F.60301@de.ibm.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <4755590F.60301-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Tue, 2007-12-04 at 14:41 +0100, Carsten Otte wrote: > Hollis Blanchard wrote: > > diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c > > --- a/drivers/kvm/kvm_main.c > > +++ b/drivers/kvm/kvm_main.c > > @@ -18,6 +18,7 @@ > > #include "kvm.h" > > #include "x86.h" > > #include "irq.h" > > +#include "iodev.h" > > > > #include > > #include > Why do we have that include in kvm_main? I will need to get rid of it > for s390 later on. Just because of the call to kvm_iodevice_destructor(). I would be happy to see kvm_io_bus_* moved out to its own files as well, which would solve this issue. -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4